Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Fix unique validator for ChoiceField#5026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| # If this model field contains choices, then return early. | ||
| # Further keyword arguments are not valid. | ||
| kwargs['choices']=model_field.choices | ||
| returnkwargs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Granted this may not be failing any tests, but I'm pretty wary.
Let's make sure that we're testing the case that this describes (a field that would result in adding keyword args thataren't valid on ChoiceField)
jpadilla commentedMar 28, 2017
Closing in favor of#5028 |
Description
Fix missing unique validators in ChoiceFields.Closes#5004
Any better place to put this test?