encode/django-rest-frameworkPublic

NotificationsYou must be signed in to change notification settings
Fork7k
Star29.8k

Use verbose_name instead of object_name in error messages#4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

lovelydinosaur merged 3 commits intoencode:masterfromsassanh:master

Jul 26, 2016

Merged

Use verbose_name instead of object_name in error messages#4299

lovelydinosaur merged 3 commits intoencode:masterfromsassanh:master

Jul 26, 2016

Conversation

Copy link

Contributor

sassanh commentedJul 24, 2016

Note: Before submitting this pull request, please review ourcontributing guidelines.

Description

It should useverbose_name, notobject_name, took me 2 hours to find out why parts of error were not translated as I didn't expect it to happen in drf.

sassanh added2 commits

July 24, 2016 04:57

use verbose_name instead of object_name in field_mapping

9342d9e

-

9a5efea

sassanh mentioned this pull request

Jul 24, 2016

Error messages are not fully translated#4300

Closed

5 tasks

Copy link

ContributorAuthor

sassanh commentedJul 24, 2016

Related to#4300.

Copy link

Contributor

lovelydinosaur commentedJul 26, 2016

Yup this looks good, thanks!
Note that there's a test case that also needs to be updated as part of this pull request.

tests/test_validators.py:80: in test_is_not_uniqueassert serializer.errors == {'username': ['UniquenessModel with this username already exists.']}E   AssertionError: assert {'username': ...ady exists.']} == {'username': [...ady exists.']}E     Differing items:E     {'username': ['uniqueness model with this username already exists.']} != {'username': ['UniquenessModel with this username already exists.']}

lovelydinosaur added the Bug label

Jul 26, 2016

Copy link

ContributorAuthor

sassanh commentedJul 26, 2016

I'll upgrade the test, could you please review my 2 commits and tell me which one is the right one?

-

09d5f85

Copy link

codecov-io commentedJul 26, 2016•
edited
Loading

Current coverage is 91.19% (diff: 100%)

Merging#4299 intomaster will increase coverage by<.01%

@@             master      #4299   diff @@==========================================  Files            52         52            Lines          5776       5781     +5     Methods           0          0            Messages          0          0            Branches          0          0          ==========================================+ Hits           5267       5272     +5  Misses          509        509            Partials          0          0

Powered byCodecov. Last update0f61c9e...09d5f85

Copy link

Contributor

lovelydinosaur commentedJul 26, 2016•
edited
Loading

I'll upgrade the test, could you please review my 2 commits and tell me which one is the right one?

Sorry, could you be more explicit?
The change in the PR looks correct, as it currently stands.

sassanh reviewed

Jul 26, 2016

View reviewed changes

rest_framework/utils/field_mapping.py

		return'%(model_name)s-detail'% {
		'app_label':model._meta.app_label,
		'model_name':model._meta.verbose_name.lower()
		'model_name':model._meta.object_name.lower()