Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Add LICENSE.md to the built wheel#4270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The wheel released on Pypi does not include the license file .The way to do this is by updating the setup.cfg accordingly
codecov-io commentedJul 15, 2016
Current coverage is91.18%@@ master #4270 diff @@========================================== Files 52 52 Lines 5776 5776 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== Hits 5267 5267 Misses 509 509 Partials 0 0
|
Contributor
lovelydinosaur commentedJul 18, 2016
Great, thanks for this! |
ContributorAuthor
pombredanne commentedAug 1, 2016
@tomchristie Thannks! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wheel released on Pypi does not include the license file . The way to do this is by updating the setup.cfg accordingly. This fix will ensure that the LICENSE.md file is available in the
dist-infodir of the built wheels asLICENSE.txt.This way folks redistribution an official DRF wheel are complying with the BSD license... otherwise they would not by virtue of not including the license text!