DecimalField has some support for non strict number of decimal places (checking here and there thatdecimal_places is not None but it fails inquantize() with "unsupported operand type(s) for ** or pow(): 'Decimal' and 'NoneType'".

This changeset fixes the problem and allowsDecimalField to handledecimal_places=None. Tests added too.

Fixed DecimalField arbitrary precision support

5e3f7c4

jpadilla added the Enhancement label

Apr 27, 2016

jpadilla added this to the3.3.4 Release milestone

Apr 27, 2016

Copy link

Contributor

jpadilla commentedApr 27, 2016

@dvarrazzo good stuff, thanks! Anyone else has any objections/comments?

lovelydinosaur merged commit88c80fe intoencode:master

Apr 27, 2016

Copy link

Contributor

lovelydinosaur commentedApr 27, 2016

Good stuff 👍

dvarrazzo deleted the no-decimal-places branch

April 27, 2016 16:48

lovelydinosaur modified the milestones:3.3.4 Release,3.4.0 Release

Jun 1, 2016

pyup-bot mentioned this pull request

Oct 22, 2016

Pin djangorestframework to latest version 3.5.1wooyek/django-website-pro#16

Merged

pyup-bot mentioned this pull request

Oct 30, 2016

Pin djangorestframework to latest version 3.5.1Cyberbyte-Software/Sensor-Portal#49

Merged

Copy link

Contributor

glarrain commentedNov 29, 2016

@dvarrazzo @jpadilla @tomchristie isdecimal_places=None allowed then? We should update the docs to make that clear (I volunteer to do so).

On the other hand, why are argsdecimal_places andmax_digits required then? As mentioned by@xordoquy here, those that are not kwargs to__init__ are supposed to be required (because they can not be set to a default value).