Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Fixed TimeField not handling string times.#3809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xordoquy commentedJan 7, 2016
I think with a test case it'll be ready to merge. |
areski commentedJan 8, 2016
@xordoquy here the test, I could not find it when I opened the PR but after more digging I think I found it. |
rest_framework/fields.py Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is it works ok on python 2.* withunicode values? Seems similar to#3819
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you updatestr tosix.string_types ? (as per#3819 indeed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure, I will then update bothDateField &TimeField to usesix.string_types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@areski TheDateTime was out of this PR scope and now conflict with master. Could you merge it please ?
xordoquy commentedJan 11, 2016
Thanks :) |
areski commentedJan 11, 2016
Thanks for the heads-up :) |
Fixed TimeField not handling empty values
xordoquy commentedJan 11, 2016
Thanks for the work ! |
areski commentedJan 11, 2016
Thanks for the guidance! On Mon, Jan 11, 2016 at 12:29 PM, Xavier Ordoquynotifications@github.com
Kind regards, Arezqui Belaid,areski@gmail.com Tel: +34650784355 |
Similar to#3731 but for TimeField