Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Fix template.render deprecation warnings for Django 1.9#3654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
rest_framework/renderers.py Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should go to the compat.py file and should be similar to the new API.
xordoquy commentedNov 18, 2015
Thanks for fixing this. I think the code should be moved to compat.py and be given an API similar to Django's new one. |
andreif commentedNov 18, 2015
Ok, I fix |
3bf5dfd to802ee5dCompareandreif commentedNov 18, 2015
@xordoquy Done. |
lovelydinosaur commentedNov 18, 2015
Looks good - thanks! |
Fix template.render deprecation warnings for Django 1.9
jezdez commentedNov 24, 2015
We're trying to switch to Django 1.8 using django-jinja which expects to be passed a request to the render method. I was wondering if the condition whether to pass in the request could be modified in DRF to be checking for |
xordoquy commentedNov 25, 2015
Indeed, this seems to have slip through. |
xordoquy commentedNov 25, 2015
@jezdez thanks for the report ! |
Passing
RequestContexttoTemplate.renderis deprecated, seedjango/django#3883https://github.com/django/django/blob/1.9rc1/django/template/backends/django.py#L82-L84