encode/django-rest-frameworkPublic

NotificationsYou must be signed in to change notification settings
Fork7k
Star29.7k

Markdown compat#3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

mjschultz wants to merge5 commits intoencode:masterfrommjschultz:markdown-compat

Closed

Markdown compat#3604

mjschultz wants to merge5 commits intoencode:masterfrommjschultz:markdown-compat

Conversation

Copy link

Contributor

mjschultz commentedNov 5, 2015

The currentapply_markdown generates the followingDeprecationWarnings:

markdown/__init__.py:143: DeprecationWarning: "safe_mode" is deprecated in Python-Markdown. Use an HTML sanitizer (like Bleach http://bleach.readthedocs.org/) if you are parsing untrusted markdown text. See the 2.6 release notes for more infomarkdown/__init__.py:222: DeprecationWarning: Setting configs in the Named Extension string is deprecated. It is recommended that you pass an instance of the extension class to Markdown or use the "extension_configs" keyword. The current behavior will raise an error in version 2.7. See the Release Notes for Python-Markdown version 2.6 for more info.markdown/__init__.py:259: DeprecationWarning: Using short names for Markdown's builtin extensions is deprecated. Use the full path to the extension with Python's dot notation (eg: "markdown.extensions.headerid" instead of "headerid"). The current behavior will raise an error in version 2.7. See the Release Notes for Python-Markdown version 2.6 for more info.

These three commits correct them per thePython-Markdown 2.6 release notes.

mjschultz added3 commits

November 5, 2015 10:47

Remove safe_mode since it is not safe.

276bc3b

Use full python dot path to extension

d9d34e4

Use markdown 2.6 extension_configs to configure extension

b2e74fb

jpadilla added the Cleanup label

Nov 6, 2015

Copy link

Contributor

jpadilla commentedNov 6, 2015

@mjschultz looks good to me, thanks!

Copy link

Contributor

lovelydinosaur commentedNov 9, 2015

Great. Which versions does this now work against? Do we need to double check that against what we current list as supported?

Copy link

ContributorAuthor

mjschultz commentedNov 9, 2015

It looks likeextension_configs was introduced inpython-markdown 2.5 which has been out for a year. I'm not sure what version(s) of markdown you'd like to support down to though?

Is there a way to automate this or should I manually verify markdown versions from current down to something?

Copy link

ContributorAuthor

mjschultz commentedNov 9, 2015

Here is what I have right now running./runtests.py --fast:

env	py2.7	py3.4
markdown==2.6.4	x	x
markdown==2.5.2	x	x
markdown==2.4.1	x	x
markdown==2.3.1	x	x
markdown==2.2.1	x	x
markdown==2.1.1	x	x
markdown==2.0.3

Copy link

Contributor

lovelydinosaur commentedNov 9, 2015

Okay. Currently the homepage lists 2.1.0+ as our requirement.
We could either:

Bump to 2.2 (Not ideal since it'd be in a minor release)
Ensure that the compat handles both styles dep on what's available.
Something else?

mjschultz added2 commits

November 9, 2015 11:47

Markdown 2.1 compatible

abc6fa0

Bump the markdown optional requirement as well

f308900

Copy link

ContributorAuthor

mjschultz commentedNov 9, 2015

Okay, it turns out in markdown 2.2 they changed the extensions framework a bit to permit external modules with more ease. This means that 2.1 would force amarkdown.extensions in front of theheaderid causing the errors.

I added some changes that checkmarkdown.version and set the headerid extension path based on that. I updated the checklist above.

I also bumped the markdown version inrequirements-optionals.txt.