Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Fixed #2761 - ListField truncation on HTTP PATCH#3415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- When not submitting key for list fields or multiple choice, partial serialization should result in empty state (key not there), not an empty list.
- Checked ``partial`` state when getting value in appropriate field classes; return ``empty`` immediately if key not submitted.
xordoquy added a commit that referenced this pull requestSep 21, 2015
Fixed#2761 - ListField truncation on HTTP PATCH
Contributor
xordoquy commentedSep 21, 2015
Good job ! Thanks for the PR. |
xordoquy added a commit to linovia/django-rest-framework that referenced this pull requestSep 21, 2015
This was referencedMar 9, 2017
This was referencedOct 16, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
empty. Namely, the semantic meaning of an empty list on an update is to remove all the values. Instead, this PR changes validation internals to use the sentinel value ofemptyinstead of an empty list.ListFieldandMultipleChoiceField, for the sake of consistent code.