Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

HTML rendering for filters#3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lovelydinosaur merged 9 commits intomasterfromfilters
Oct 22, 2015
Merged

HTML rendering for filters#3315

lovelydinosaur merged 9 commits intomasterfromfilters
Oct 22, 2015

Conversation

@lovelydinosaur
Copy link
Contributor

Closes#2180.

Filters rendering in the browsable API and admin.

Remaining:

  • Docs.
  • Use translated strings throughout.
  • Render bootstrap forms directly, dropping the crispy forms optional req.
  • Consider search control rendering directly? (But could be a second pass)

This sort of thing...

image


image

@jpadilla
Copy link
Contributor

@tomchristie looking great, any specific reason for introducing the requirement for crispy forms?

@lovelydinosaur
Copy link
ContributorAuthor

@jpadilla django-filters won't render nicely with our bootstrap style out-of-the-box.

We'd probably be making it a soft requirement, but there's also a poss of movingDjangoFilterBackend into a third party package, and then including a built-in field filtering class that uses serializers (since they actually have everything we'd need to make this work).

@carltongibson
Copy link
Collaborator

there's also a poss of moving DjangoFilterBackend into a third party package

I'd be happy to maintain such a package.

I have a slight niggle about re-creating functionality that already exists; the prejudice is to consolidate effort rather than split it...

@lovelydinosaur
Copy link
ContributorAuthor

I'd be happy to maintain such a package.

That would be pretty amazing. Ideally I'd like to see us do that with both django-filter and django-guardian so that external deps are only required in external packages.

@carltongibson
Copy link
Collaborator

OK. Fine. I'll put something together.

lovelydinosaur added a commit that referenced this pull requestOct 22, 2015
First pass at HTML rendering for filters
@lovelydinosaurlovelydinosaur merged commitc53c9ed intomasterOct 22, 2015
@lovelydinosaurlovelydinosaur deleted the filters branchOctober 22, 2015 10:42
@lovelydinosaurlovelydinosaur changed the titleFirst pass at HTML rendering for filtersHTML rendering for filtersOct 22, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.3.0 Release

Development

Successfully merging this pull request may close these issues.

4 participants

@lovelydinosaur@jpadilla@carltongibson

[8]ページ先頭

©2009-2025 Movatter.jp