Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support grouped choices.#3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lovelydinosaur merged 8 commits intomasterfrommaxpeterson-grouped-choices-fix
Aug 6, 2015

Conversation

@lovelydinosaur
Copy link
Contributor

Based on the work in#3108 from@maxpeterson - Thank you!

Closes#1533.

Renders as:

image

maxpetersonand others added4 commitsJuly 3, 2015 12:27
This also adds support for mixing single and paired choices:```[    ('poor', 'Poor quality'),    'medium',    ('good', 'Good quality'),]```
@lovelydinosaur
Copy link
ContributorAuthor

@maxpeterson - We could consider something like#3101 as a follow up to this. I chose not to push that in as part of this change as a consequence of it being unclear what behavior we'd want (or even if wedo want that behavior). As you mentioned:

I am not certain what the behaviour should be

I think the bottom line might be that we wouldn't accept further complications to the already ad-hoc 'OPTIONS' behavior, however I'd be willing to consider a fresh ticket for it if you were so minded and wanted to discuss further.

lovelydinosaur added a commit that referenced this pull requestAug 6, 2015
@lovelydinosaurlovelydinosaur merged commit37b4d42 intomasterAug 6, 2015
@lovelydinosaurlovelydinosaur deleted the maxpeterson-grouped-choices-fix branchAugust 6, 2015 12:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.2.0 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@lovelydinosaur@maxpeterson

[8]ページ先頭

©2009-2025 Movatter.jp