Commitdba9493

authored

Don't evaluate default_timezone unless needed (#8531)

If you set a custom timezone for a DateTimeField, the functionself.default_timezone() is still called, since fallback params togetattr are still evaluated.This rewrites to use hasattr, so the fallback case is only executed ifit will actually be used. If you render a lot of DateTimeFields in aserializer, the time spent evaluating default_timezone() once for eachof them can accumulate to quite a bit, which is just unused work in thecase where timezone is already specified on the field.

1 parentfa9d516 commitdba9493Copy full SHA for dba9493

File tree

1 file changed

-1

lines changed

rest_framework
- fields.py

1 file changed

-1

lines changed

`‎rest_framework/fields.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1179,7 +1179,7 @@ def enforce_timezone(self, value):`
`1179`	`1179`	When `self.default_timezone` is `None`, always return naive datetimes.
`1180`	`1180`	When `self.default_timezone` is not `None`, always return aware datetimes.
`1181`	`1181`	`"""`
`1182`		`-field_timezone=getattr(self,'timezone',self.default_timezone())`
	`1182`	`+field_timezone=self.timezoneifhasattr(self,'timezone')elseself.default_timezone()`
`1183`	`1183`
`1184`	`1184`	`iffield_timezoneisnotNone:`
`1185`	`1185`	`iftimezone.is_aware(value):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitdba9493

File tree

1 file changed

1 file changed

`‎rest_framework/fields.py‎`

0 commit comments