Commit7cf5c19

committed

Fix OpenAPI operation name plural appropriately

1 parentb1004a4 commit7cf5c19Copy full SHA for 7cf5c19

File tree

+19

-2

lines changed

+19

-2

lines changed

Lines changed: 1 addition & 0 deletions

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`	`)`
`12`	`12`	`fromdjango.dbimportmodels`
`13`	`13`	`fromdjango.utils.encodingimportforce_str`
	`14`	`+frominflectionimportpluralize`
`14`	`15`
`15`	`16`	`fromrest_frameworkimport (`
`16`	`17`	`RemovedInDRF314Warning,exceptions,renderers,serializers`
`@@ -247,8 +248,8 @@ def get_operation_id_base(self, path, method, action):`
`247`	`248`	`ifname.endswith(action.title()):# ListView, UpdateAPIView, ThingDelete ...`
`248`	`249`	`name=name[:-len(action)]`
`249`	`250`
`250`		`-ifaction=='list'andnotname.endswith('s'):# listThings instead of listThing`
`251`		`-name+='s'`
	`251`	`+ifaction=='list':`
	`252`	`+name=pluralize(name)`
`252`	`253`
`253`	`254`	`returnname`
`254`	`255`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -695,6 +695,21 @@ def test_operation_id_custom_name(self):`
`695`	`695`	`operationId=inspector.get_operation_id(path,method)`
`696`	`696`	`assertoperationId=='listUlysses'`
`697`	`697`
	`698`	`+deftest_operation_id_plural(self):`
	`699`	`+path='/'`
	`700`	`+method='GET'`
	`701`	`+`
	`702`	`+view=create_view(`
	`703`	`+views.ExampleGenericAPIView,`
	`704`	`+method,`
	`705`	`+create_request(path),`
	`706`	`+ )`
	`707`	`+inspector=AutoSchema(operation_id_base='City')`
	`708`	`+inspector.view=view`
	`709`	`+`
	`710`	`+operationId=inspector.get_operation_id(path,method)`
	`711`	`+assertoperationId=='listCities'`
	`712`	`+`
`698`	`713`	`deftest_operation_id_override_get(self):`
`699`	`714`	`classCustomSchema(AutoSchema):`
`700`	`715`	`defget_operation_id(self,path,method):`

Comments

(0)