Commit53e1a2f

Carlton Gibson

committed

Merge pull request#2637 from mdentremont/topic/allow-serialize-unsaved-with-relations

Support serializing unsaved models with related fields.

2 parents0e21f1c +fb58ef0 commit53e1a2fCopy full SHA for 53e1a2f

File tree

+24

-0

lines changed

+24

-0

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -360,6 +360,10 @@ def to_internal_value(self, data):`
`360`	`360`	`]`
`361`	`361`
`362`	`362`	`defget_attribute(self,instance):`
	`363`	`+# Can't have any relationships if not created`
	`364`	`+ifnotinstance.pk:`
	`365`	`+return []`
	`366`	`+`
`363`	`367`	`relationship=get_attribute(instance,self.source_attrs)`
`364`	`368`	`returnrelationship.all()if (hasattr(relationship,'all'))elserelationship`
`365`	`369`

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -143,6 +143,16 @@ def test_many_to_many_create(self):`
`143`	`143`	`]`
`144`	`144`	`self.assertEqual(serializer.data,expected)`
`145`	`145`
	`146`	`+deftest_many_to_many_unsaved(self):`
	`147`	`+source=ManyToManySource(name='source-unsaved')`
	`148`	`+`
	`149`	`+serializer=ManyToManySourceSerializer(source)`
	`150`	`+`
	`151`	`+expected= {'id':None,'name':'source-unsaved','targets': []}`
	`152`	`+# no query if source hasn't been created yet`
	`153`	`+withself.assertNumQueries(0):`
	`154`	`+self.assertEqual(serializer.data,expected)`
	`155`	`+`
`146`	`156`	`deftest_reverse_many_to_many_create(self):`
`147`	`157`	`data= {'id':4,'name':'target-4','sources': [1,3]}`
`148`	`158`	`serializer=ManyToManyTargetSerializer(data=data)`
`@@ -296,6 +306,16 @@ def test_foreign_key_update_with_invalid_null(self):`
`296`	`306`	`self.assertFalse(serializer.is_valid())`
`297`	`307`	`self.assertEqual(serializer.errors, {'target': ['This field may not be null.']})`
`298`	`308`
	`309`	`+deftest_foreign_key_with_unsaved(self):`
	`310`	`+source=ForeignKeySource(name='source-unsaved')`
	`311`	`+expected= {'id':None,'name':'source-unsaved','target':None}`
	`312`	`+`
	`313`	`+serializer=ForeignKeySourceSerializer(source)`
	`314`	`+`
	`315`	`+# no query if source hasn't been created yet`
	`316`	`+withself.assertNumQueries(0):`
	`317`	`+self.assertEqual(serializer.data,expected)`
	`318`	`+`
`299`	`319`	`deftest_foreign_key_with_empty(self):`
`300`	`320`	`"""`
`301`	`321`	`Regression test for #1072`

Comments

(0)