Commit51265fa

ismaeljs

committed

add warning when min_value and max_value are not decimal

1 parente08e606 commit51265faCopy full SHA for 51265fa

File tree

+19

-0

lines changed

+19

-0

lines changed

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`importdecimal`
`5`	`5`	`importfunctools`
`6`	`6`	`importinspect`
	`7`	`+importlogging`
`7`	`8`	`importre`
`8`	`9`	`importuuid`
`9`	`10`	`fromcollections.abcimportMapping`
`@@ -38,6 +39,8 @@`
`38`	`39`	`fromrest_framework.utils.timezoneimportvalid_datetime`
`39`	`40`	`fromrest_framework.validatorsimportProhibitSurrogateCharactersValidator`
`40`	`41`
	`42`	`+logger=logging.getLogger("rest_framework.fields")`
	`43`	`+`
`41`	`44`
`42`	`45`	`classempty:`
`43`	`46`	`"""`
`@@ -990,6 +993,11 @@ def __init__(self, max_digits, decimal_places, coerce_to_string=None, max_value=`
`990`	`993`	`self.max_value=max_value`
`991`	`994`	`self.min_value=min_value`
`992`	`995`
	`996`	`+ifself.max_valueisnotNoneandnotisinstance(self.max_value,decimal.Decimal):`
	`997`	`+logger.warning("max_value in fields.DecimalField should be Decimal type.")`
	`998`	`+ifself.min_valueisnotNoneandnotisinstance(self.min_value,decimal.Decimal):`
	`999`	`+logger.warning("min_value in fields.DecimalField should be Decimal type.")`
	`1000`	`+`
`993`	`1001`	`ifself.max_digitsisnotNoneandself.decimal_placesisnotNone:`
`994`	`1002`	`self.max_whole_digits=self.max_digits-self.decimal_places`
`995`	`1003`	`else:`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1216,6 +1216,17 @@ class TestMinMaxDecimalField(FieldValues):`
`1216`	`1216`	`min_value=10,max_value=20`
`1217`	`1217`	`)`
`1218`	`1218`
	`1219`	`+deftest_warning_when_not_decimal_types(self,caplog):`
	`1220`	`+importlogging`
	`1221`	`+serializers.DecimalField(`
	`1222`	`+max_digits=3,decimal_places=1,`
	`1223`	`+min_value=10,max_value=20`
	`1224`	`+ )`
	`1225`	`+assertcaplog.record_tuples== [`
	`1226`	`+ ("rest_framework.fields",logging.WARNING,"max_value in fields.DecimalField should be Decimal type."),`
	`1227`	`+ ("rest_framework.fields",logging.WARNING,"min_value in fields.DecimalField should be Decimal type.")`
	`1228`	`+ ]`
	`1229`	`+`
`1219`	`1230`
`1220`	`1231`	`classTestAllowEmptyStrDecimalFieldWithValidators(FieldValues):`
`1221`	`1232`	`"""`

Comments

(0)