Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add ALC_EXT_capture to present OpenAL extensions#25837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sbc100 merged 1 commit intoemscripten-core:mainfrominolen:alc_ext_capture
Dec 18, 2025

Conversation

@inolen
Copy link
Collaborator

The extension is already implemented, however, alcIsExtensionPresent wasn't reporting it as present.

Copy link
Collaborator

@sbc100sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we add this one an existing test maybe?

@inoleninolenforce-pushed thealc_ext_capture branch 2 times, most recently from119224c tob181970CompareDecember 18, 2025 09:04
@inolen
Copy link
CollaboratorAuthor

Updated the existing test with this extension.

Copy link
Collaborator

@sbc100sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@sbc100
Copy link
Collaborator

Can you runtest/runner codesize --rebase (withemsdk install tot first) to update the codesize expectations.

@inolen
Copy link
CollaboratorAuthor

inolen commentedDec 18, 2025•
edited
Loading

Do I just runemsdk install tot or do i need to install and then switch to it somehow? Haven't used emsdk much, I just followed along with the README to use my git fork and then frantically throw commands at my terminal until it works each time I have to update.

@inoleninolenforce-pushed thealc_ext_capture branch 3 times, most recently from1618c81 to684c214CompareDecember 18, 2025 21:10
@sbc100
Copy link
Collaborator

Looks like main is currently out-of-date WRT codesize .. I will update there and you can rebase.

@sbc100
Copy link
Collaborator

codesizes updated in#25983

The extension is already implemented, however, alcIsExtensionPresentwasn't reporting it as present.
@inolen
Copy link
CollaboratorAuthor

I assume this failure is related to some of the recent commits, not this 😆

@sbc100
Copy link
Collaborator

Landing without waiting for tests to pass since codesize tests have passed and the wasm2js failure looks unrelated.

@sbc100sbc100 merged commit5f59cb6 intoemscripten-core:mainDec 18, 2025
24 of 35 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sbc100sbc100sbc100 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@inolen@sbc100
[8]ページ先頭
©2009-2025 Movatter.jp