- Notifications
You must be signed in to change notification settings - Fork208
- Enum-based TX enable mode#300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
milen100 commentedAug 6, 2023
I like it ! It is a useful change. |
emelianov commentedOct 14, 2023
Could you refactor of Enum declaration to not break API compatibility: enumModbusRTUTxEnableMode:bool {/** * The TX enable pin should be high when transmitting */TxEnableHigh= true,/** * The TX enable pin should be low when transmitting */TxEnableLow= false }; |
lmartorella commentedOct 14, 2023
Hi, |
rob040 commentedDec 15, 2023
To add my 2ct... I do like the first solution <0141b93>, but there are always more ways to achieve the same. @lmartorella notice your ABI note v.s. API compatibility request. These libraries are source level, so ABI compatibility is never needed |
Hello,
It is probably better to introduce an enum-based value for the current
txEnableDirect, to have a more self-explaining API, not requiring to look at the documentation to understand what really 'direct' mean in logic terms (e.g. from an electronic point of view, usually levels are negated, so 'direct' can be quite confusing here).What do you think about it?
Thx! L