- Notifications
You must be signed in to change notification settings - Fork585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: add new setting to select line height options#3034
base:main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview forelk-docs canceled.
|
✅ Deploy Preview forelk-zone ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
26b8f6b tob24b53cCompareNew and removed dependencies detected. Learn more aboutSocket for GitHub ↗︎
🚮 Removed packages:npm/@iconify/json@2.2.170,npm/@iconify/utils@2.1.32 |
| @@ -125,8 +125,16 @@ em-emoji-picker { | |||
| } | |||
| } | |||
| .line-compact { | |||
| line-height: calc(4 / 3 * 1em); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Removed the unitem following the recommendation by MDN (https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#values):
In most cases,this is the preferred way to set line-height and avoid unexpected results due to inheritance.
resolve#3007
This PR implements a new setting to select line height in the post body. Users can choose the narrower (1.2) or wider (1.5) line height options, in addition to the current normal option (4/3)
Screenshots
Setting section for line height
Narrow (1.2)
Normal (4/3 = 1.33...): current and default value
Wide (1.5)