Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

feat: add credits to creators in link previews usingfediverse:creator#3012

Merged
patak-dev merged 5 commits intomainfromshuuji3/feat/more-from-author-on-card
Oct 26, 2024

Conversation

shuuji3
Copy link
Member

@shuuji3shuuji3 commentedOct 21, 2024
edited
Loading

resolve#2995

(This change requires masto.js v6.10.0+ to support Mastodon v4.3.0+)

To implement a new author link on the footer, I mimicked the design on mastodon.social but any feedback is welcome.


screenshot of the post with a new author link

https://mastodon.social/@Mastodon/113272025176822566

Before (or Mastodon < v4.3.0)

Screenshot of the post with link preview

After (with Mastodon v4.3.0+)

Screenshot of the post with link preview. There is an extra footer below the link preview information that says "More from Eugen Rochko" with an avatar icon image

Screenshot of the post with link preview in timeline

https://deploy-preview-3012--elk-zone.netlify.app/mastodon.social/@Mastodon/112718231305707672

userquin reacted with heart emoji
@netlifyNetlify
Copy link

netlifybot commentedOct 21, 2024
edited
Loading

Deploy Preview forelk-docs canceled.

NameLink
🔨 Latest commitc844511
🔍 Latest deploy loghttps://app.netlify.com/sites/elk-docs/deploys/6719c453f695e800086908d4

@netlifyNetlify
Copy link

netlifybot commentedOct 21, 2024
edited
Loading

Deploy Preview forelk-zone ready!

NameLink
🔨 Latest commitc844511
🔍 Latest deploy loghttps://app.netlify.com/sites/elk-zone/deploys/6719c453744d1b0007e9f6e9
😎 Deploy Previewhttps://deploy-preview-3012--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@shuuji3shuuji3 marked this pull request as ready for reviewOctober 21, 2024 16:02
@shuuji3
Copy link
MemberAuthor

shuuji3 commentedOct 21, 2024
edited
Loading

universedon.com uses Mastodon v4.2.10, so we need to log in to another instance with Mastodon v4.3.0 (likemastodon.social) to check the change in the preview.

my-auto
bg-gray-300
>
<span z-0>More from</span>
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I addedz-0 here because the below<AccountInlineInfo> component covers the part of the text when hovering.

Copy link
Member

@patak-devpatak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome!

shuuji3 reacted with heart emoji
@patak-devpatak-dev added this pull request to themerge queueOct 26, 2024
Merged via the queue intomain with commit41346e3Oct 26, 2024
15 checks passed
@patak-devpatak-dev deleted the shuuji3/feat/more-from-author-on-card branchOctober 26, 2024 06:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@patak-devpatak-devpatak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add credits to creators in link previews usingfediverse:creator
2 participants
@shuuji3@patak-dev

[8]ページ先頭

©2009-2025 Movatter.jp