- Notifications
You must be signed in to change notification settings - Fork583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix(ui): change apple app status bar style#2903
Conversation
✅ Deploy Preview forelk-docs canceled.
|
✅ Deploy Preview forelk-zone ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
|
uhmm, we should just switch the flag here:https://github.com/elk-zone/elk/blob/main/nuxt.config.ts#L264 @DasLixou can you send a new PR changing to default previous line? |
Oh interesting it was already there :0 yeah, can do that, but I'll do it in here to track everything |
I was wondering why an explicit default would change something but with the other line being overwritten that makes sense |
switching to dark theme should also work, can you confirm that? |
I tested that with my old changes yes, and the new one set the same property, so it should work |
yep, works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thx ❤️
Co-authored-by: Joaquín Sánchez <userquin@gmail.com>
On my iPhone, with a PWA, the status bar is always white, which makes it unreadable in white mode.
In this PR, I try to get this to work with the selected theme.
Because I don't know how to debug it differently, I'll use the hosted PR example to test.
Closes#2384