- Notifications
You must be signed in to change notification settings - Fork584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix: fixvue/no-ref-as-operand andvue/return-in-computed-property ESLint errors#2679
Merged
patak-dev merged 2 commits intoelk-zone:mainfromshuuji3:fix/eslint-vue-no-ref-as-operand-errorsMar 11, 2024
Merged
fix: fixvue/no-ref-as-operand andvue/return-in-computed-property ESLint errors#2679
patak-dev merged 2 commits intoelk-zone:mainfromshuuji3:fix/eslint-vue-no-ref-as-operand-errorsMar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
|
✅ Deploy Preview forelk-docs canceled.
|
✅ Deploy Preview forelk-zone ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
f94f340 to6e57c16Compareuserquin approved these changesMar 11, 2024
patak-dev approved these changesMar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh, this is great! These would explain a lot of the bugs we are seeing. Sorry I missed all of them 😬
Let's merge and do a new release
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see#2678 for how to temporarily enable some vue-related ESLint rules