NotificationsYou must be signed in to change notification settings
Fork584
Star5.7k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

fix: remember last accessed notification tab#2654

Merged

patak-dev merged 1 commit intoelk-zone:mainfromshuuji3:fix/preserve-mention-tab

Mar 6, 2024

Merged

fix: remember last accessed notification tab#2654

patak-dev merged 1 commit intoelk-zone:mainfromshuuji3:fix/preserve-mention-tab

Mar 6, 2024

Conversation

Copy link

Member

shuuji3 commentedMar 6, 2024

fix#1058

This allows Elk to remember the last accessed tab including filters like "Favorite" and "Reblog", not only the "Mentions" tab.

How to test

Navigate to the "Notification" page.
Select the "Mentions" tab or any other filters.
Move to the other page.
Navigate to the "Notification" page again.
See if the previous tab is shown (not the default "All" tab).

Copy link

stackblitzbot commentedMar 6, 2024

Run & review this pull request inStackBlitz Codeflow.

Copy link

netlifybot commentedMar 6, 2024•
edited
Loading

✅ Deploy Preview forelk-docs canceled.

Name	Link
🔨 Latest commit	`fe59e52`
🔍 Latest deploy log	https://app.netlify.com/sites/elk-docs/deploys/65e86e6bf9062800084ec79d

Copy link

netlifybot commentedMar 6, 2024•
edited
Loading

✅ Deploy Preview forelk-zone ready!

Name	Link
🔨 Latest commit	`fe59e52`
🔍 Latest deploy log	https://app.netlify.com/sites/elk-zone/deploys/65e86e6bf289b300084a38f5
😎 Deploy Preview	https://deploy-preview-2654--elk-zone.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

shuuji3 changed the title~~feat: remember last accessed notification tab~~fix: remember last accessed notification tab

Mar 6, 2024

feat: remember last accessed notification tab

fe59e52

shuuji3 force-pushed thefix/preserve-mention-tab branch from7ff4409 tofe59e52Compare

March 6, 2024 13:23

Copy link

Member

userquin commentedMar 6, 2024

@shuuji3 looks good, but we also have tabs inexplore andaccount routes

Copy link

MemberAuthor

shuuji3 commentedMar 6, 2024•
edited
Loading

Ah, that's right. Let me create a separate PR for each.

Theexplore one should be able to be implemented with a similar logic. I'll look into related components later. Theaccount one will need some adjustment on storage value to remember for each account.