- Notifications
You must be signed in to change notification settings - Fork584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: put account name copy button#2347
Conversation
|
✅ Deploy Preview forelk-docs ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
✅ Deploy Preview forelk-zone ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
✅ Deploy Preview forelk-zone ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
components/account/AccountHeader.vue Outdated
| <div flex items-center gap-1> | ||
| <AccountHandle :account="account" overflow-unset line-clamp-unset /> | ||
| <CommonTooltip placement="bottom" :content="$t('account.copy_account_name')" no-auto-focus flex> | ||
| <button text-secondary-light text-sm i-ri:file-copy-line @click="copyAccountName"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would be great if the button had some sort of response, like changing the icon to a checkmark and changing back after a few seconds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for the review.🙂 That's a good suggestion. I modified it to show a check mark for 2 seconds.
550ac95 tod27603aCompared27603a tof120cc2CompareNew check mark after clicking: copy-check.mp4 |
This is one option to solve#2199. Please see the issue for details and other options.