Commit3854728

authored and

committed

Fix parser crash on missing parentheses on expression following operator \"not in\" warning (#15011)

1 parent4f07670 commit3854728Copy full SHA for 3854728

File tree

+20

-0

lines changed

lib/elixir
- src
  - elixir_parser.yrl
- test/elixir/kernel
  - warning_test.exs

+20

-0

lines changed

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1298,6 +1298,14 @@ warn_pipe(_Token, _) ->`
`1298`	`1298`	`ok.`
`1299`	`1299`
`1300`	`1300`	`%% TODO: Make this an error on v2.0`
	`1301`	`+warn_no_parens_after_do_op({{in_op,Location,Op,_InLocation},_})->`
	`1302`	`+ {Line,_,_}=Location,`
	`1303`	`+`
	`1304`	`+warn(`
	`1305`	`+Line,`
	`1306`	`+"missing parentheses on expression following operator\""++atom_to_list(Op)++"\","`
	`1307`	`+"you must add parentheses to avoid ambiguities"`
	`1308`	`+ );`
`1301`	`1309`	`warn_no_parens_after_do_op({{_Type,Location,Op},_})->`
`1302`	`1310`	`{Line,_,_}=Location,`
`1303`	`1311`

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1953,6 +1953,18 @@ defmodule Kernel.WarningTest do`
`1953`	`1953`	`)`
`1954`	`1954`	`end`
`1955`	`1955`
	`1956`	`+test"do+end with not in operator without explicit parentheses"do`
	`1957`	`+assert_warn_eval(`
	`1958`	`+["nofile:3\n","missing parentheses on expression following operator\"not in\""],`
	`1959`	`+"""`
	`1960`	`+ quote do`
	`1961`	`+ case do`
	`1962`	`+ end not in no_parens 1, 2`
	`1963`	`+ end`
	`1964`	`+ """`
	`1965`	`+)`
	`1966`	`+end`
	`1967`	`+`
`1956`	`1968`	`test"variable is being expanded to function call (on_undefined_variable: warn)"do`
`1957`	`1969`	`capture_io(:stderr,fn->`
`1958`	`1970`	`Code.put_compiler_option(:on_undefined_variable,:warn)`

Comments

(0)