Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Backport staging] Wire up the "Forgot recovery key" button for the "Key storage out of sync" toast#29190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
t3chguy merged 2 commits intostagingfrombackport-29138-to-staging
Feb 7, 2025

Conversation

RiotRobot
Copy link
Contributor

Backport9657d39 from#29138.

…sync" toast (#29138)* Wire up the "Forgot recovery key" button for the "Key storage out of sync" toast* Unused import & fix test* Test 'forgot' variant* Fix dependencies* Add more toast tests* Unused import* Test initialState in Encryption Tab* Let's see if github has any more luck running this test than me* Working playwright test with screenshot* year* Convert playwright test to use the bot client* DisambiguateCo-authored-by: Florian Duros <florianduros@element.io>* Add doc & do other part of rename* Split out into custom hook* Fix tests---------Co-authored-by: Florian Duros <florianduros@element.io>(cherry picked from commit9657d39)
Copy link
Member

@richvdhrichvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks like a backport, but I have some comments on the original PR, which looks like it only got a cursory review.

Copy link
Member

@richvdhrichvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

wrong button

Copy link
Member

@richvdhrichvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hum it's good enough for a backport

@t3chguyt3chguy added this pull request to themerge queueFeb 5, 2025
@github-merge-queuegithub-merge-queuebot removed this pull request from themerge queue due to failed status checksFeb 5, 2025
@dbkr
Copy link
Member

dbkr commentedFeb 6, 2025

I'm assuming this will need the merge queue bypassing as I guess it's not running against consistent versions of the js-sdk or something?

@t3chguy
Copy link
Member

I'm going to try fix the branch matching as its important to check these PRs, backporting is high-risk

@t3chguyt3chguy added this pull request to themerge queueFeb 7, 2025
Merged via the queue intostaging with commit8941724Feb 7, 2025
28 checks passed
@t3chguyt3chguy deleted the backport-29138-to-staging branchFebruary 7, 2025 00:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@richvdhrichvdhrichvdh approved these changes

@floriandurosfloriandurosflorianduros approved these changes

@dbkrdbkrAwaiting requested review from dbkrdbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-DefectX-Release-BlockerZ-Community-PRIssue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@RiotRobot@dbkr@t3chguy@richvdh@florianduros
[8]ページ先頭
©2009-2025 Movatter.jp