Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.2k
Stop showing a dialog prompting the user to enter an old recovery key#29143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
9716dec to09d745dCompare09d745d toa45a1c9CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tests are failing ...
We don't really support the concept of having multiple 4S keys active, soprompting the user to enter a non-default 4S key without even telling themwhich one we want is rather silly.
We seem to already have about 5 copies of this code, so before I add another,let's factor it out.
This should be fixed by the previous commit, so let's check it stays that way.
a45a1c9 todbd3417Compareoops, my bad. Now fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice fix.
Uh oh!
There was an error while loading.Please reload this page.
099c307Uh oh!
There was an error while loading.Please reload this page.
Currently, if we need a secret that is stored in 4S under anold recovery key, we put up a modal prompting the user to enter that old key, but don't actually tell them which key it is we are after.
Our design doesn't really support having more than one recovery key at a time -- we tell our users that there is only one recovery key.
So, it's better to treat such secrets as non-existent, rather than bothering the user for access.
Fixes:#29130.
Suggest review commit-by-commit.