Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Schedule dehydration on reload if the dehydration key is already cached locally#29021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

uhoreg
Copy link
Member

@uhoreguhoreg commentedJan 17, 2025•
edited
Loading

Depends onmatrix-org/matrix-js-sdk#4664

Fixes#29031

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updatedpublic/exported symbols have accurateTSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing theContributor License Agreement (CLA)

@uhoreguhoreg changed the titleSchedule dehydration on reloadSchedule dehydration on reload if the dehydration key is already cachedJan 29, 2025
@uhoreguhoreg changed the titleSchedule dehydration on reload if the dehydration key is already cachedSchedule dehydration on reload if the dehydration key is already cached locallyJan 29, 2025
@uhoreguhoreg marked this pull request as ready for reviewJanuary 30, 2025 15:50
@uhoreguhoreg requested a review froma team as acode ownerJanuary 30, 2025 15:50
Copy link
Member

@andybalaamandybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, thanks.

@uhoreguhoreg added this pull request to themerge queueJan 31, 2025
Merged via the queue intoelement-hq:develop with commit4cba79dJan 31, 2025
46 of 47 checks passed
@uhoreguhoreg deleted the schedule_dehydration_on_reload branchJanuary 31, 2025 18:42
Comment on lines 41 to +44
* @param createNewKey: force a new dehydration key to be created, even if one
* already exists. This is used when we reset secret storage.
*/
export async function initialiseDehydration(createNewKey: boolean = false): Promise<void> {
const crypto = MatrixClientPeg.safeGet().getCrypto();
if (await deviceDehydrationEnabled(crypto)) {
export async function initialiseDehydration(opts: StartDehydrationOpts = {}, client?: MatrixClient): Promise<void> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@andybalaam@uhoreg please can we make sure that we update thedocumentation when we update the signature of a public function?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(fix in#29261)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@richvdhrichvdhrichvdh left review comments

@andybalaamandybalaamandybalaam approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device Dehydration | element-web: schedule dehydration if dehydration key is stored
3 participants
@uhoreg@andybalaam@richvdh
[8]ページ先頭
©2009-2025 Movatter.jp