Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Style room header icons and facepile for toggled state#28968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MidhunSureshR merged 11 commits intodevelopfrommidhun/room-header-active-icons
Jan 27, 2025

Conversation

MidhunSureshR
Copy link
Member

Forhttps://github.com/element-hq/wat-internal/issues/240 andhttps://github.com/element-hq/wat-internal/issues/242

According to the figma designs, the toggled on state of the room header buttons should look like:
image

and the face pile should look like:
image

So that we track changes to the right panel phases
We do this so that we can get by using a single event listener i.e weonly need to call `useCurrentPhase` in the provider as opposed tocalling it in each header icon.
and adds a class name when the corresponding panel is open
@MidhunSureshRMidhunSureshR added this pull request to themerge queueJan 27, 2025
@github-merge-queuegithub-merge-queuebot removed this pull request from themerge queue due to failed status checksJan 27, 2025
@MidhunSureshRMidhunSureshR added this pull request to themerge queueJan 27, 2025
@github-merge-queuegithub-merge-queuebot removed this pull request from themerge queue due to failed status checksJan 27, 2025
@MidhunSureshRMidhunSureshR added this pull request to themerge queueJan 27, 2025
Merged via the queue intodevelop with commitf29ce94Jan 27, 2025
33 checks passed
@MidhunSureshRMidhunSureshR deleted the midhun/room-header-active-icons branchJanuary 27, 2025 15:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@t3chguyt3chguyt3chguy approved these changes

@dbkrdbkrAwaiting requested review from dbkrdbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@MidhunSureshR@t3chguy
[8]ページ先頭
©2009-2025 Movatter.jp