Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.2k
AddAdvanced section to the user settings encryption tab#28804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
5055c46 to85ce1ccCompare85ce1cc to32ec0d2Compare32ec0d2 to6467943Comparea8dd23c to00a85d8Compare380ef62 to8bd5d6aCompare00a85d8 toa2a2512Compare9841d92 tofd51450Comparefd51450 to8f98a63Compare8f98a63 to58d2f91Compare74c9a7b to7ddd021CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
From a crypto standpoint, looks sane. There's a wording thing that I'm not completely happy with, but it may be good enough.
| "breadcrumb_first_description": "Your account details, contacts, preferences, and chat list will be kept", | ||
| "breadcrumb_page": "Reset encryption", | ||
| "breadcrumb_second_description": "You will lose any message history that’s stored only on the server", | ||
| "breadcrumb_third_description": "You will need to verify all your existing devices and contacts again", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this could be a bit misleading, as it says that the user needs to verify all their contacts, whereas they really only need to re-verify contacts that they had already verified. Though I don't know how to word it better without being overly wordy. So maybe it's OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The wording is coming fromfigma design
ac565dcUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Checklist
public/exportedsymbols have accurateTSDoc documentation.Task#26468
Closes#28977
Requiredmatrix-org/matrix-js-sdk#4614
Figma design
Add a new section to the encryption tab of the user settings. This section adds: