Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make themed widgets reflect the effective theme#28342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

robintown
Copy link
Member

@robintownrobintown commentedOct 30, 2024•
edited
Loading

So that widgets such as Element Call will show up in the right theme even if the app is set to match the system theme.

Closes#27671
Depends onmatrix-org/matrix-widget-api#117

Copy link
Member

@t3chguyt3chguy left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure this is the right solution given that system theme often changes based on time (day/night), and widgets have no way to receive a theme change. Maybe a widget should just make its own media queries if there is no provided theme to match system theme and that way it can respond to theme changes.

@robintown
Copy link
MemberAuthor

Apologies for the force pushes. This is ready for another review but blocked on a related matrix-widget-api change.

So that widgets such as Element Call will show up in the right theme even if the app is set to match the system theme.
@hughns
Copy link
Member

I'm not sure this is the right solution given that system theme often changes based on time (day/night), and widgets have no way to receive a theme change. Maybe a widget should just make its own media queries if there is no provided theme to match system theme and that way it can respond to theme changes.

@robintown have these concerns been addressed?

@robintown
Copy link
MemberAuthor

robintown commentedJan 10, 2025•
edited
Loading

Yes, they have. I'm now updating the theme dynamically with a widget action.

@robintownrobintown added this pull request to themerge queueJan 28, 2025
Merged via the queue intoelement-hq:develop with commitc453d33Jan 28, 2025
28 checks passed
@robintownrobintown deleted the widget-effective-theme branchJanuary 28, 2025 11:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@t3chguyt3chguyt3chguy approved these changes

@toger5toger5toger5 approved these changes

@MidhunSureshRMidhunSureshRAwaiting requested review from MidhunSureshRMidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calls use the wrong theme
4 participants
@robintown@hughns@t3chguy@toger5
[8]ページ先頭
©2009-2025 Movatter.jp