Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4k
Improve external dependency compatibility: native module detection and DLL exclusion option#3702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Mulgyeol wants to merge2 commits intoelectron-react-boilerplate:mainChoose a base branch fromMulgyeol:fix/native-dep-dll-compat
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+14 −23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Only treat packages as native dependencies if they have a binding.gyp file and are listed in package.json dependencies.Remove unnecessary npm ls parsing and try-catch block.Prevents false positives that could block development.
Introduce a dllExclude array in webpack.config.renderer.dev.dll.ts to allow users to easily exclude problematic packages from the DLL bundle.By default, the array is empty. Users can add package names as needed for their environment.Improves flexibility and compatibility with external dependencies.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve External Dependency Compatibility: Native Module Detection & DLL Exclusion Option
Description
While working with Electron React Boilerplate, I noticed that some external packages—especially those with native modules or special export/dynamic import requirements—were causing unexpected build failures.
This PR updates the native module detection logic to be more accurate and adds a simple way for users to exclude problematic packages from the DLL bundle. I believe these changes will make it much easier to integrate a wider variety of dependencies without running into confusing errors.
Changes Made
.erb/scripts/check-native-dep.js
binding.gyp
file and a direct entry inpackage.json
dependencies are flagged as native.npm ls
parsing and the try-catch block..erb/configs/webpack.config.renderer.dev.dll.ts
dllExclude
array, allowing users to easily specify packages to exclude from the DLL bundle.Why
Testing
dllExclude
successfully excludes them from the DLL bundle.