Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

More resilient publish workflow options#3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jessedp wants to merge2 commits intoelectron-react-boilerplate:main
base:main
Choose a base branch
Loading
fromjessedp:more-resilient-publish

Conversation

jessedp
Copy link
Contributor

This solves two challenges I faced when upgrading the publish workflow:

  1. Without the signing environment vars setup in GH, the build breaks
    • I didn't test this, but I imagine defining them with incorrect values is also unhelpful
  2. Building a "msi", "rpm", or "deb" under only MacOs caused build problems. Running each build on the native OS has so far allowed those to work.

This setup (with some other stuff) is running/working overhere.

@amilajack
Copy link
Member

Thanks for this :)

A few questions:

Building a "msi", "rpm", or "deb" under only MacOs caused build problems.

what build problems did you run into?

@jessedp
Copy link
ContributorAuthor

It's possible that I was fightingpublishing timeout problems.

Not sure if you can see the logs, butthese are the runs from the branch I was testing on (DEBUG=electron-builder* is set).

If you can, here'sone example that's not just a publish timeout.

I guess one additional benefit is that this also enables more parallel/"faster" builds.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jessedp@amilajack
[8]ページ先頭
©2009-2025 Movatter.jp