Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: updateBrowserView#lastWindowSize after window resize#43463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@mai-121
Copy link
Contributor

@mai-121mai-121 commentedAug 23, 2024•
edited by codebytere
Loading

Description of Change

Closes#43462

During BrowserView auto-resize, the new size is calculated using BrowserView#lastWindowSize, but lastWindowSize is never updated and remains the value from the initial window size. This results in BrowserView being resized incorrectly.
To fix this issue, we should update lastWindowSize to the current window size after it has been used.

Checklist

Release Notes

Notes: Fixed BrowserView auto resize issue.

@welcome
Copy link

welcomebot commentedAug 23, 2024

💖 Thanks for opening this pull request! 💖

Semantic PR titles

We usesemantic commit messages to streamline the release process. Before your pull request can be merged, you shouldupdate your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Commit signing

This repo enforcescommit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation onTelling Git about your signing key.

PR tips

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Pythoncoding style.
  • Runnpm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following thedocumentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cationelectron-cationbot added the new-pr 🌱PR opened recently labelAug 23, 2024
@codebyterecodebytere changed the titlefix: update BrowserView#lastWindowSize after window resize (#43462)fix: updateBrowserView#lastWindowSize after window resizeAug 26, 2024
@codebyterecodebytere added target/31-x-yPR should also be added to the "31-x-y" branch. target/32-x-yPR should also be added to the "32-x-y" branch. target/33-x-yPR should also be added to the "33-x-y" branch. labelsAug 26, 2024
@codebytere
Copy link
Member

@mai-121 please address the extra spaces on line 148 (see lint failure) and we can get this merged 😁

@mai-121
Copy link
ContributorAuthor

@codebytere Thank you, I will sign these commits tomorrow.

@mai-121mai-121force-pushed thefix/browser_view_auto_resize branch from287ee3c to0daf35cCompareAugust 29, 2024 05:06
Copy link
Member

@yangannyxyangannyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great!

@mai-121
Copy link
ContributorAuthor

mai-121 commentedAug 30, 2024•
edited
Loading

@codebytere Appveyor run failed in win-woa-testing, is there anything I can do to resolve it?

@electron-cationelectron-cationbot removed the new-pr 🌱PR opened recently labelAug 30, 2024
@codebytere
Copy link
Member

@mai-121 could you please rebase this on main? once that's done i'll shepherd it in :)

@codebyterecodebytere added the semver/patchbackwards-compatible bug fixes labelSep 4, 2024
@mai-121mai-121force-pushed thefix/browser_view_auto_resize branch from766f75a toe93038fCompareSeptember 4, 2024 10:51
@mai-121
Copy link
ContributorAuthor

@codebytere done.

@codebyterecodebytere merged commite2fe8f5 intoelectron:mainSep 9, 2024
@welcome
Copy link

welcomebot commentedSep 9, 2024

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

Release Notes Persisted

Fixed BrowserView auto resize issue.

@trop
Copy link
Contributor

tropbot commentedSep 9, 2024

I have automatically backported this PR to "31-x-y", please check out#43635

@troptropbot added in-flight/31-x-y and removed target/31-x-yPR should also be added to the "31-x-y" branch. labelsSep 9, 2024
@trop
Copy link
Contributor

tropbot commentedSep 9, 2024

I have automatically backported this PR to "33-x-y", please check out#43636

@trop
Copy link
Contributor

tropbot commentedSep 9, 2024

I have automatically backported this PR to "32-x-y", please check out#43637

@troptropbot added in-flight/33-x-y in-flight/32-x-y and removed target/33-x-yPR should also be added to the "33-x-y" branch. target/32-x-yPR should also be added to the "32-x-y" branch. labelsSep 9, 2024
@mai-121mai-121 deleted the fix/browser_view_auto_resize branchSeptember 9, 2024 15:01
@troptropbot added merged/32-x-yPR was merged to the "32-x-y" branch. merged/33-x-yPR was merged to the "33-x-y" branch. merged/31-x-yPR was merged to the "31-x-y" branch. and removed in-flight/32-x-y in-flight/33-x-y in-flight/31-x-y labelsSep 9, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@codebyterecodebyterecodebytere approved these changes

+1 more reviewer

@yangannyxyangannyxyangannyx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged/31-x-yPR was merged to the "31-x-y" branch.merged/32-x-yPR was merged to the "32-x-y" branch.merged/33-x-yPR was merged to the "33-x-y" branch.semver/patchbackwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: BrowserView do not auto resize correctly

3 participants

@mai-121@codebytere@yangannyx
[8]ページ先頭
©2009-2025 Movatter.jp