Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitceb76a5

Browse files
fix: cookies filter secure invalid (#37248)
fix: cookies filter secure and session invalidCo-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>Co-authored-by: Black-Hole1 <158blackhole@gmail.com>
1 parent38f4017 commitceb76a5

File tree

2 files changed

+67
-2
lines changed

2 files changed

+67
-2
lines changed

‎shell/browser/api/electron_api_cookies.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,10 @@ bool MatchesCookie(const base::Value::Dict& filter,
128128
!MatchesDomain(*str, cookie.Domain()))
129129
returnfalse;
130130
absl::optional<bool> secure_filter = filter.FindBool("secure");
131-
if (secure_filter && *secure_filter== cookie.IsSecure())
131+
if (secure_filter && *secure_filter!= cookie.IsSecure())
132132
returnfalse;
133133
absl::optional<bool> session_filter = filter.FindBool("session");
134-
if (session_filter && *session_filter!= !cookie.IsPersistent())
134+
if (session_filter && *session_filter==cookie.IsPersistent())
135135
returnfalse;
136136
returntrue;
137137
}

‎spec/api-net-spec.ts

Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -800,6 +800,71 @@ describe('net module', () => {
800800
});
801801
}
802802

803+
it('should be able correctly filter out cookies that are secure',async()=>{
804+
constsess=session.fromPartition(`cookie-tests-${Math.random()}`);
805+
806+
awaitPromise.all([
807+
sess.cookies.set({
808+
url:'https://electronjs.org',
809+
domain:'electronjs.org',
810+
name:'cookie1',
811+
value:'1',
812+
secure:true
813+
}),
814+
sess.cookies.set({
815+
url:'https://electronjs.org',
816+
domain:'electronjs.org',
817+
name:'cookie2',
818+
value:'2',
819+
secure:false
820+
})
821+
]);
822+
823+
constsecureCookies=awaitsess.cookies.get({
824+
secure:true
825+
});
826+
expect(secureCookies).to.have.lengthOf(1);
827+
expect(secureCookies[0].name).to.equal('cookie1');
828+
829+
constcookies=awaitsess.cookies.get({
830+
secure:false
831+
});
832+
expect(cookies).to.have.lengthOf(1);
833+
expect(cookies[0].name).to.equal('cookie2');
834+
});
835+
836+
it('should be able correctly filter out cookies that are session',async()=>{
837+
constsess=session.fromPartition(`cookie-tests-${Math.random()}`);
838+
839+
awaitPromise.all([
840+
sess.cookies.set({
841+
url:'https://electronjs.org',
842+
domain:'electronjs.org',
843+
name:'cookie1',
844+
value:'1'
845+
}),
846+
sess.cookies.set({
847+
url:'https://electronjs.org',
848+
domain:'electronjs.org',
849+
name:'cookie2',
850+
value:'2',
851+
expirationDate:Math.round(Date.now()/1000)+10000
852+
})
853+
]);
854+
855+
constsessionCookies=awaitsess.cookies.get({
856+
session:true
857+
});
858+
expect(sessionCookies).to.have.lengthOf(1);
859+
expect(sessionCookies[0].name).to.equal('cookie1');
860+
861+
constcookies=awaitsess.cookies.get({
862+
session:false
863+
});
864+
expect(cookies).to.have.lengthOf(1);
865+
expect(cookies[0].name).to.equal('cookie2');
866+
});
867+
803868
describe('when {"credentials":"omit"}',()=>{
804869
it('should not send cookies');
805870
it('should not store cookies');

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp