Commit39ee940

authored

fix: add missingset_wants_to_be_visible(true) toNativeWindowMac::ShowInactive() (#40546)

* fix: add missing set_wants_to_be_visible(true) to NativeWindowMac::ShowInactive()* add test

1 parentb2fcc15 commit39ee940Copy full SHA for 39ee940

File tree

+30

-0

lines changed

+30

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -534,6 +534,8 @@ void ReorderChildWindowAbove(NSWindow* child_window, NSWindow* other_window) {`
`534`	`534`	`}`
`535`	`535`
`536`	`536`	`voidNativeWindowMac::ShowInactive() {`
	`537`	`+set_wants_to_be_visible(true);`
	`538`	`+`
`537`	`539`	`// Reattach the window to the parent to actually show it.`
`538`	`540`	`if (parent())`
`539`	`541`	`InternalSetParentWindow(parent(),true);`

Lines changed: 28 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1144,6 +1144,34 @@ describe('BrowserWindow module', () => {`
`1144`	`1144`	`awaitshown;`
`1145`	`1145`	`expect(w.isMaximized()).to.equal(true);`
`1146`	`1146`	`});`
	`1147`	`+`
	`1148`	`+ifit(process.platform==='darwin')('should attach child window to parent',async()=>{`
	`1149`	`+constwShow=once(w,'show');`
	`1150`	`+w.show();`
	`1151`	`+awaitwShow;`
	`1152`	`+`
	`1153`	`+constc=newBrowserWindow({show:false,parent:w});`
	`1154`	`+constcShow=once(c,'show');`
	`1155`	`+c.showInactive();`
	`1156`	`+awaitcShow;`
	`1157`	`+`
	`1158`	`+// verifying by checking that the child tracks the parent's visibility`
	`1159`	`+constminimized=once(w,'minimize');`
	`1160`	`+w.minimize();`
	`1161`	`+awaitminimized;`
	`1162`	`+`
	`1163`	`+expect(w.isVisible()).to.be.false('parent is visible');`
	`1164`	`+expect(c.isVisible()).to.be.false('child is visible');`
	`1165`	`+`
	`1166`	`+constrestored=once(w,'restore');`
	`1167`	`+w.restore();`
	`1168`	`+awaitrestored;`
	`1169`	`+`
	`1170`	`+expect(w.isVisible()).to.be.true('parent is visible');`
	`1171`	`+expect(c.isVisible()).to.be.true('child is visible');`
	`1172`	`+`
	`1173`	`+closeWindow(c);`
	`1174`	`+});`
`1147`	`1175`	`});`
`1148`	`1176`
`1149`	`1177`	`describe('BrowserWindow.focus()',()=>{`

Comments

(0)