Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit0c892fc

Browse files
trop[bot]ckerr
andauthored
fix: enable some tests that were accidentally disabled (#46846)
* fix: tests that were not run in api-app-spec due to nested it()Co-authored-by: Charles Kerr <charles@charleskerr.com>* fix: tests that were not run in api-browser-window-spec due to nested it()Co-authored-by: Charles Kerr <charles@charleskerr.com>* chore: annotate disabled testCo-authored-by: Charles Kerr <charles@charleskerr.com>---------Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>Co-authored-by: Charles Kerr <charles@charleskerr.com>
1 parenta95d9a4 commit0c892fc

File tree

2 files changed

+24
-23
lines changed

2 files changed

+24
-23
lines changed

‎spec/api-app-spec.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ describe('app module', () => {
8484
});
8585

8686
describe('app name APIs',()=>{
87-
it('with properties',()=>{
87+
describe('with properties',()=>{
8888
it('returns the name field of package.json',()=>{
8989
expect(app.name).to.equal('Electron Test Main');
9090
});
@@ -98,7 +98,7 @@ describe('app module', () => {
9898
});
9999
});
100100

101-
it('with functions',()=>{
101+
describe('with functions',()=>{
102102
it('returns the name field of package.json',()=>{
103103
expect(app.getName()).to.equal('Electron Test Main');
104104
});
@@ -988,7 +988,7 @@ describe('app module', () => {
988988
});
989989
});
990990

991-
it('with functions',()=>{
991+
describe('with functions',()=>{
992992
it('can set accessibility support enabled',()=>{
993993
expect(app.isAccessibilitySupportEnabled()).to.eql(false);
994994

‎spec/api-browser-window-spec.ts‎

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2101,13 +2101,14 @@ describe('BrowserWindow module', () => {
21012101
});
21022102

21032103
ifdescribe(process.platform==='win32')('Fullscreen state',()=>{
2104-
it('with properties',()=>{
2104+
describe('with properties',()=>{
21052105
it('can be set with the fullscreen constructor option',()=>{
21062106
w=newBrowserWindow({fullscreen:true});
21072107
expect(w.fullScreen).to.be.true();
21082108
});
21092109

2110-
it('does not go fullscreen if roundedCorners are enabled',async()=>{
2110+
// FIXME: this test needs to be fixed and re-enabled.
2111+
it.skip('does not go fullscreen if roundedCorners are enabled',async()=>{
21112112
w=newBrowserWindow({frame:false,roundedCorners:false,fullscreen:true});
21122113
expect(w.fullScreen).to.be.false();
21132114
});
@@ -2185,7 +2186,7 @@ describe('BrowserWindow module', () => {
21852186
});
21862187
});
21872188

2188-
it('with functions',()=>{
2189+
describe('with functions',()=>{
21892190
it('can be set with the fullscreen constructor option',()=>{
21902191
w=newBrowserWindow({fullscreen:true});
21912192
expect(w.isFullScreen()).to.be.true();
@@ -5433,7 +5434,7 @@ describe('BrowserWindow module', () => {
54335434
afterEach(closeAllWindows);
54345435

54355436
describe('movable state',()=>{
5436-
it('with properties',()=>{
5437+
describe('with properties',()=>{
54375438
it('can be set with movable constructor option',()=>{
54385439
constw=newBrowserWindow({show:false,movable:false});
54395440
expect(w.movable).to.be.false('movable');
@@ -5449,7 +5450,7 @@ describe('BrowserWindow module', () => {
54495450
});
54505451
});
54515452

5452-
it('with functions',()=>{
5453+
describe('with functions',()=>{
54535454
it('can be set with movable constructor option',()=>{
54545455
constw=newBrowserWindow({show:false,movable:false});
54555456
expect(w.isMovable()).to.be.false('movable');
@@ -5467,7 +5468,7 @@ describe('BrowserWindow module', () => {
54675468
});
54685469

54695470
ifdescribe(process.platform==='darwin')('documentEdited state',()=>{
5470-
it('with properties',()=>{
5471+
describe('with properties',()=>{
54715472
it('can be changed',()=>{
54725473
constw=newBrowserWindow({show:false});
54735474
expect(w.documentEdited).to.be.false();
@@ -5476,7 +5477,7 @@ describe('BrowserWindow module', () => {
54765477
});
54775478
});
54785479

5479-
it('with functions',()=>{
5480+
describe('with functions',()=>{
54805481
it('can be changed',()=>{
54815482
constw=newBrowserWindow({show:false});
54825483
expect(w.isDocumentEdited()).to.be.false();
@@ -5507,7 +5508,7 @@ describe('BrowserWindow module', () => {
55075508
});
55085509

55095510
describe('native window title',()=>{
5510-
it('with properties',()=>{
5511+
describe('with properties',()=>{
55115512
it('can be set with title constructor option',()=>{
55125513
constw=newBrowserWindow({show:false,title:'mYtItLe'});
55135514
expect(w.title).to.eql('mYtItLe');
@@ -5521,7 +5522,7 @@ describe('BrowserWindow module', () => {
55215522
});
55225523
});
55235524

5524-
it('with functions',()=>{
5525+
describe('with functions',()=>{
55255526
it('can be set with minimizable constructor option',()=>{
55265527
constw=newBrowserWindow({show:false,title:'mYtItLe'});
55275528
expect(w.getTitle()).to.eql('mYtItLe');
@@ -5537,7 +5538,7 @@ describe('BrowserWindow module', () => {
55375538
});
55385539

55395540
describe('minimizable state',()=>{
5540-
it('with properties',()=>{
5541+
describe('with properties',()=>{
55415542
it('can be set with minimizable constructor option',()=>{
55425543
constw=newBrowserWindow({show:false,minimizable:false});
55435544
expect(w.minimizable).to.be.false('minimizable');
@@ -5553,7 +5554,7 @@ describe('BrowserWindow module', () => {
55535554
});
55545555
});
55555556

5556-
it('with functions',()=>{
5557+
describe('with functions',()=>{
55575558
it('can be set with minimizable constructor option',()=>{
55585559
constw=newBrowserWindow({show:false,minimizable:false});
55595560
expect(w.isMinimizable()).to.be.false('movable');
@@ -5639,7 +5640,7 @@ describe('BrowserWindow module', () => {
56395640
});
56405641

56415642
ifdescribe(process.platform==='win32')('maximizable state',()=>{
5642-
it('with properties',()=>{
5643+
describe('with properties',()=>{
56435644
it('is reset to its former state',()=>{
56445645
constw=newBrowserWindow({show:false});
56455646
w.maximizable=false;
@@ -5653,7 +5654,7 @@ describe('BrowserWindow module', () => {
56535654
});
56545655
});
56555656

5656-
it('with functions',()=>{
5657+
describe('with functions',()=>{
56575658
it('is reset to its former state',()=>{
56585659
constw=newBrowserWindow({show:false});
56595660
w.setMaximizable(false);
@@ -5766,7 +5767,7 @@ describe('BrowserWindow module', () => {
57665767
});
57675768

57685769
ifdescribe(process.platform==='darwin')('fullscreenable state',()=>{
5769-
it('with functions',()=>{
5770+
describe('with functions',()=>{
57705771
it('can be set with fullscreenable constructor option',()=>{
57715772
constw=newBrowserWindow({show:false,fullscreenable:false});
57725773
expect(w.isFullScreenable()).to.be.false('isFullScreenable');
@@ -5833,7 +5834,7 @@ describe('BrowserWindow module', () => {
58335834
});
58345835

58355836
ifdescribe(process.platform==='darwin')('isHiddenInMissionControl state',()=>{
5836-
it('with functions',()=>{
5837+
describe('with functions',()=>{
58375838
it('can be set with ignoreMissionControl constructor option',()=>{
58385839
constw=newBrowserWindow({show:false,hiddenInMissionControl:true});
58395840
expect(w.isHiddenInMissionControl()).to.be.true('isHiddenInMissionControl');
@@ -5853,7 +5854,7 @@ describe('BrowserWindow module', () => {
58535854
// fullscreen events are dispatched eagerly and twiddling things too fast can confuse poor Electron
58545855

58555856
ifdescribe(process.platform==='darwin')('kiosk state',()=>{
5856-
it('with properties',()=>{
5857+
describe('with properties',()=>{
58575858
it('can be set with a constructor property',()=>{
58585859
constw=newBrowserWindow({kiosk:true});
58595860
expect(w.kiosk).to.be.true();
@@ -5874,7 +5875,7 @@ describe('BrowserWindow module', () => {
58745875
});
58755876
});
58765877

5877-
it('with functions',()=>{
5878+
describe('with functions',()=>{
58785879
it('can be set with a constructor property',()=>{
58795880
constw=newBrowserWindow({kiosk:true});
58805881
expect(w.isKiosk()).to.be.true();
@@ -6173,7 +6174,7 @@ describe('BrowserWindow module', () => {
61736174
});
61746175

61756176
describe('closable state',()=>{
6176-
it('with properties',()=>{
6177+
describe('with properties',()=>{
61776178
it('can be set with closable constructor option',()=>{
61786179
constw=newBrowserWindow({show:false,closable:false});
61796180
expect(w.closable).to.be.false('closable');
@@ -6189,7 +6190,7 @@ describe('BrowserWindow module', () => {
61896190
});
61906191
});
61916192

6192-
it('with functions',()=>{
6193+
describe('with functions',()=>{
61936194
it('can be set with closable constructor option',()=>{
61946195
constw=newBrowserWindow({show:false,closable:false});
61956196
expect(w.isClosable()).to.be.false('isClosable');
@@ -6207,7 +6208,7 @@ describe('BrowserWindow module', () => {
62076208
});
62086209

62096210
describe('hasShadow state',()=>{
6210-
it('with properties',()=>{
6211+
describe('with properties',()=>{
62116212
it('returns a boolean on all platforms',()=>{
62126213
constw=newBrowserWindow({show:false});
62136214
expect(w.shadow).to.be.a('boolean');

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp