Commit2432eb0

committed

fix: always attempt to set the legacy token env var

Any npm command, include `npm version` attempts to exapand the `LEGACY_TOKEN` environment varialbe if it is set in `.npmrc`.

1 parente8fe729 commit2432eb0Copy full SHA for 2432eb0

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,12 +23,13 @@ async function verifyConditions(pluginConfig, context) {`
`23`	`23`
`24`	`24`	`consterrors=verifyNpmConfig(pluginConfig);`
`25`	`25`
	`26`	`+setLegacyToken(context);`
	`27`	`+`
`26`	`28`	`try{`
`27`	`29`	`constpkg=awaitgetPkg(pluginConfig,context);`
`28`	`30`
`29`	`31`	// Verify the npm authentication only if `npmPublish` is not false and `pkg.private` is not `true`
`30`	`32`	`if(pluginConfig.npmPublish!==false&&pkg.private!==true){`
`31`		`-setLegacyToken(context);`
`32`	`33`	`awaitverifyNpmAuth(pluginConfig,pkg,context);`
`33`	`34`	`}`
`34`	`35`	`}catch(error){`
`@@ -44,11 +45,12 @@ async function prepare(pluginConfig, context) {`
`44`	`45`	`letpkg;`
`45`	`46`	`consterrors=verified ?[] :verifyNpmConfig(pluginConfig);`
`46`	`47`
	`48`	`+setLegacyToken(context);`
	`49`	`+`
`47`	`50`	`try{`
`48`	`51`	`// Reload package.json in case a previous external step updated it`
`49`	`52`	`pkg=awaitgetPkg(pluginConfig,context);`
`50`	`53`	`if(!verified&&pluginConfig.npmPublish!==false&&pkg.private!==true){`
`51`		`-setLegacyToken(context);`
`52`	`54`	`awaitverifyNpmAuth(pluginConfig,pkg,context);`
`53`	`55`	`}`
`54`	`56`	`}catch(error){`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ test('Skip npm auth verification if "package.private" is true', async t => {`
`65`	`65`	`{npmPublish:false},`
`66`	`66`	`{`
`67`	`67`	`cwd,`
	`68`	`+env:{},`
`68`	`69`	`options:{publish:['@semantic-release/npm']},`
`69`	`70`	`stdout:t.context.stdout,`
`70`	`71`	`stderr:t.context.stderr,`
`@@ -83,6 +84,7 @@ test('Skip npm token verification if "package.private" is true', async t => {`
`83`	`84`	`{},`
`84`	`85`	`{`
`85`	`86`	`cwd,`
	`87`	`+env:{},`
`86`	`88`	`options:{publish:['@semantic-release/npm']},`
`87`	`89`	`stdout:t.context.stdout,`
`88`	`90`	`stderr:t.context.stderr,`

Comments

(0)