- Notifications
You must be signed in to change notification settings - Fork545
[Apache.Access] Added response_time in microseconds as a field to apache access data_stream#9913
[Apache.Access] Added response_time in microseconds as a field to apache access data_stream#9913ishleenk17 merged 6 commits intoelastic:mainfromAlphayeeeet:main
Conversation
and re-generated test specs
Alphayeeeet commentedMay 17, 2024
Please label the PR as an enhancement as I have no permissions to set labels. |
ali786XI commentedMay 20, 2024
/test |
Uh oh!
There was an error while loading.Please reload this page.
ali786XI commentedMay 21, 2024
/test |
elasticmachine commentedMay 21, 2024
🚀 Benchmarks reportTo see the full report comment with |
ali786XI left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Approving this PR but we'll need one more round of review from someone in @elastic/obs-infraobs-integrations
Alphayeeeet commentedJun 11, 2024
@aliabbas-elastic @elastic/obs-infraobs-integrations Are there any update on merging this PR by now? |
Alphayeeeet commentedJun 20, 2024
@aliabbas-elastic Can u run CI again? I have resolved some merge conflicts in the changelog. Unfortunately this PR ist still not merged. Is there anyone from @elastic/obs-infraobs-integrations I could ping to give some review for this PR? We might need this changes internally soon, thats why this PR should be merged. |
Alphayeeeet commentedJun 20, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@ishleenk17 As I have seen, you have reviewed the other PR as well. Is it possible for you to review this PR? It is open for quite some time now. |
packages/apache/data_stream/access/elasticsearch/ingest_pipeline/default.yml OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
ali786XI commentedJun 20, 2024
/test |
ali786XI commentedJun 20, 2024
/test |
elasticmachine commentedJun 20, 2024
💚 Build Succeeded
History
|
ishleenk17 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks. The changes look good now!
elasticmachine commentedJun 20, 2024
Package apache - 1.20.0 containing this change is available athttps://epr.elastic.co/search?package=apache |
Uh oh!
There was an error while loading.Please reload this page.
Added response_time in microseconds as a field to apache access data_stream
The response_time was added as an optional log parameter in a separate grok pattern, so that it is fully backwards compatible. The new log format, which includes %D was documented in the README as well as the newly added field.
The reason behind this, is to allow response_time to be collected (as in our environment we need it) and therefore a dashboard which uses that could maybe be added in the future.
Checklist
changelog.ymlfile.