Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

packages/aws/data_stream/lambda: Add Async metrics#9782

Merged
agithomas merged 11 commits intoelastic:mainfrom
agithomas:issue-1371-aync-fields
May 6, 2024
Merged

packages/aws/data_stream/lambda: Add Async metrics#9782
agithomas merged 11 commits intoelastic:mainfrom
agithomas:issue-1371-aync-fields

Conversation

@agithomas
Copy link
Contributor

@agithomasagithomas commentedMay 3, 2024•
edited
Loading

Proposed commit message

  • Add async event age and async event drops metrics.
  • Add sum aggregation metrics for Throttle, Errors, DeadLetterErrors, DestinationDeliveryFailures metrics.
  • Update Error dashboard with sum aggregation metrics
  • Update dashboard with async event age and async event drop metrics

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

Author's Checklist

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry
  • Dashboard data verification
  • Package upgrade verification
  • Index mapping verification

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry

Screenshots

image

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with/test benchmark fullreport

@agithomasagithomas marked this pull request as ready for reviewMay 4, 2024 06:15
@agithomasagithomas requested review froma team ascode ownersMay 4, 2024 06:15
Copy link
Contributor

@efd6efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nits only

@ali786XIali786XI self-requested a reviewMay 6, 2024 05:47
Copy link
Contributor

@ali786XIali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some minor nits and dashboard changes requested. Dashboard changes are not specific with the changes in this PR but they are kind of minor improvements which can be done alongside

shmsr reacted with thumbs up emoji
Copy link
Member

@shmsrshmsr left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please check all avg.Error average fields will have "per minute" in the definition as the aggregates are done on one-minute intervals.

Please check unchanged avg fields if they have the average mentioned in their description.

- name: AsyncEventsReceived.sum
type: long
metric_type: gauge
description: The number of events that Lambda successfully queues for processing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
description:The number of events that Lambda successfullyqueues for processing.
description:The number ofasynchronousevents that Lambda successfullyadds to the function event queue.

@shmsrshmsr added the enhancementNew feature or request labelMay 6, 2024
@shmsrshmsr changed the titleAdd AWS Lambda Async metricspackages/aws/data_stream/lambda: Add Async metricsMay 6, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One more thing came to my mind seeing the updated screenshot. For visualizationsAsync Event Wait andAsync Events Received their@timestamp interval is set toAuto which is correct and thetimestamp per x mins/secs/hours would change dynamically as per the duration selected above. However forTop Errors andLambda Function Duration same is not reflected. Can we check there if something else is set in there?

@agithomas
Copy link
ContributorAuthor

Please check all avg.Error average fields will have "per minute" in the definition as the aggregates are done on one-minute intervals.

This is not true. The blog was merely mentioning on how the in-built cloud watch dashboard is built on.

image

In elastic integration, the user has the flexibility to choose thePeriod and aggregations occur based on the configuredPeriod value.

@shmsr
Copy link
Member

shmsr commentedMay 6, 2024•
edited
Loading

Please check all avg.Error average fields will have "per minute" in the definition as the aggregates are done on one-minute intervals.

This is not true. The blog was merely mentioning on how the in-built cloud watch dashboard is built on.

image

In elastic integration, the user has the flexibility to choose thePeriod and aggregations occur based on the configuredPeriod value.

Got it. Then let's not add the per minute change I suggested. Or we can replace "per minute" to "per configured period". Is it by default 1m?

@agithomas
Copy link
ContributorAuthor

Got it. Then let's not add the per minute change I suggested. Or we can replace "per minute" to "per configured period". Is it by default 1m?

Theperiod settings is applicable for all the fields in this integration. Specifically calling out for this field alone may not be needed, i think

shmsr reacted with thumbs up emoji

@agithomasagithomas requested a review fromali786XIMay 6, 2024 10:23
@agithomasagithomas requested a review fromshmsrMay 6, 2024 10:23
Copy link
Contributor

@ali786XIali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@elasticmachine
Copy link

💚 Build Succeeded

History

cc@agithomas

@elastic-sonarqube
Copy link

Quality Gate passedQuality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@agithomasagithomas merged commit3202bcd intoelastic:mainMay 6, 2024
@elasticmachine
Copy link

Package aws - 2.15.0 containing this change is available athttps://epr.elastic.co/search?package=aws

@agithomasagithomas deleted the issue-1371-aync-fields branchFebruary 12, 2025 04:59
@andrewkrohandrewkroh added the dashboardRelates to a Kibana dashboard bug, enhancement, or modification. labelMar 13, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ishleenk17ishleenk17ishleenk17 left review comments

@shmsrshmsrshmsr approved these changes

@efd6efd6efd6 approved these changes

+1 more reviewer

@ali786XIali786XIali786XI approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@agithomasagithomas

Labels

dashboardRelates to a Kibana dashboard bug, enhancement, or modification.enhancementNew feature or requestIntegration:awsAWS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@agithomas@elasticmachine@shmsr@efd6@ishleenk17@ali786XI@andrewkroh

Comments

[8]ページ先頭
©2009-2026 Movatter.jp