Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

Enable secret for the identified fields in multiple packages#9009

Merged
ritalwar merged 19 commits intoelastic:mainfrom
ritalwar:secret_migration_1305
Feb 13, 2024
Merged

Enable secret for the identified fields in multiple packages#9009
ritalwar merged 19 commits intoelastic:mainfrom
ritalwar:secret_migration_1305

Conversation

@ritalwar
Copy link
Contributor

@ritalwarritalwar commentedJan 30, 2024•
edited
Loading

Proposed commit message

  • Enable secret for identified sensitive fields.
  • Update package-spec to 3.0.2 for most packages to utilize the validation checks for secrets.
  • Omit the package-spec update to 3.0.2 for the aws package due to additional validation check involving dynamic mappings for nested fields in the waf datastream.
  • Update Kibana version condition to 8.12 for packages on versions 8.10-8.11, as 8.12 resolves all secret-related issues.
  • For packages < 8.10.0, retain existing Kibana version. Changelog descriptions for these packages indicate that secrets are supported from version 8.12, allowing users to upgrade stack at their discretion.

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@ritalwarritalwar added the enhancementNew feature or request labelJan 30, 2024
@ritalwarritalwar self-assigned thisJan 30, 2024
@elasticmachine
Copy link

elasticmachine commentedJan 30, 2024•
edited
Loading

🚀 Benchmarks report

To see the full report comment with/test benchmark fullreport

@ritalwarritalwar marked this pull request as ready for reviewFebruary 7, 2024 10:23
@ritalwarritalwar requested review froma team ascode ownersFebruary 7, 2024 10:23
Copy link
Contributor

@harnish-crest-dataharnish-crest-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! 🚀

@andrewkrohandrewkroh added Integration:azure_application_insightsAzure Application Insights Metrics Overview Integration:azure_functionsAzure Functions Integration:citrix_adcCitrix ADC Integration:microsoft_sqlserverMicrosoft SQL Server Integration:mongodbMongoDB Integration:activemqActiveMQ Integration:azure_billingAzure Billing Metrics Integration:cassandraCassandra Integration:salesforceSalesforce Integration:azure_app_serviceAzure App Service Integration:cockroachdbCockroachDB Metrics Integration:mysqlMySQL Integration:prometheus_inputPrometheus Input Integration:spring_bootSpring Boot Integration:systemSystem Integration:vsphereVMware vSphere Integration:cephCeph Integration:kafkaKafka Integration:kafka_logCustom Kafka Logs Integration:postgresqlPostgreSQL Integration:rabbitmqRabbitMQ Logs and Metrics Integration:awsAWS Integration:nginxNginx Integration:prometheusPrometheus Integration:websphere_application_serverWebSphere Application Server Integration:apache_tomcatApache Tomcat Integration:golangGolang Integration:oracle_weblogicOracle WebLogic Integration:redisRedis labelsJul 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zmoogzmoogzmoog approved these changes

@andrewkrohandrewkrohandrewkroh approved these changes

@agithomasagithomasagithomas approved these changes

+2 more reviewers

@harnish-crest-dataharnish-crest-dataharnish-crest-data approved these changes

@ali786XIali786XIali786XI approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ritalwarritalwar

Labels

enhancementNew feature or requestIntegration:activemqActiveMQIntegration:apache_tomcatApache TomcatIntegration:awsAWSIntegration:azure_app_serviceAzure App ServiceIntegration:azure_application_insightsAzure Application Insights Metrics OverviewIntegration:azure_billingAzure Billing MetricsIntegration:azure_functionsAzure FunctionsIntegration:cassandraCassandraIntegration:cephCephIntegration:citrix_adcCitrix ADCIntegration:cockroachdbCockroachDB MetricsIntegration:golangGolangIntegration:kafka_logCustom Kafka LogsIntegration:kafkaKafkaIntegration:microsoft_sqlserverMicrosoft SQL ServerIntegration:mongodbMongoDBIntegration:mysqlMySQLIntegration:nginxNginxIntegration:oracle_weblogicOracle WebLogicIntegration:postgresqlPostgreSQLIntegration:prometheus_inputPrometheus InputIntegration:prometheusPrometheusIntegration:rabbitmqRabbitMQ Logs and MetricsIntegration:redisRedisIntegration:salesforceSalesforceIntegration:spring_bootSpring BootIntegration:systemSystemIntegration:vsphereVMware vSphereIntegration:websphere_application_serverWebSphere Application Server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ritalwar@elasticmachine@agithomas@zmoog@andrewkroh@harnish-crest-data@ali786XI
[8]ページ先頭
©2009-2026 Movatter.jp