Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

elastic/obs-infraobs-integrations: Address skipped validation SVR00004#8423

Merged
shmsr merged 10 commits intoelastic:mainfrom
shmsr:fix-validation-svr00004
Feb 7, 2024
Merged

elastic/obs-infraobs-integrations: Address skipped validation SVR00004#8423
shmsr merged 10 commits intoelastic:mainfrom
shmsr:fix-validation-svr00004

Conversation

@shmsr
Copy link
Member

@shmsrshmsr commentedNov 7, 2023•
edited
Loading

Tip: How to use the inliner script? Followthis. Also read the following:

Set this to your environment (e.g., prepend when executing the inliner script)NODE_TLS_REJECT_UNAUTHORIZED='0' to bypass certificate verification for TLS connections and HTTPS requests as elastic-package deploys the stack with TLS on by default.

Proposed commit message

Usedhttps://github.com/elastic/visualizations_integrations_tools/blob/master/inline.js to inline "by reference" viz.

  • apache_spark
  • azure_functions
  • hadoop
  • iis
  • oracle_weblogic
  • spring_boot
  • traefik
  • websphere_application_server

Couldn't migrate other packages 11 packages out of 19 packages with SVR00004 as inliner script does not support inlining saved searches because the script was developed before users could have by-value (inline) saved searches in Kibana dashboards. So those packages have references to "search" and hence SVR00004 couldn't be addressed.

Thanks to Drew for creating this related issue to update the inliner script:elastic/visualizations_integrations_tools#2

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

Author's Checklist

Here is a list of packages that have SVR00004 with the kibana.version:

activemq == ^8.8.0 apache_spark == ^8.8.0apache_tomcat == ^8.8.0azure_functions == ^8.8.1cassandra == ^8.8.0hadoop == ^8.10.2iis == ^8.8.0kafka == ^8.8.0microsoft_sqlserver == ^8.10.2mongodb == ^8.8.0mysql == ^8.8.2nginx == ^8.8.0oracle_weblogic == ^8.8.0postgresql == ^8.8.0redis == ^8.10.2spring_boot == ^8.9.0system == ^8.10.2traefik == ^8.9.0websphere_application_server == ^8.3.0
  • Note that, using the inliner script will make the dashboards incompatible with earlier versions of the stack. For example, if the inliner script is used with 8.8 stack then the dashboard generated will be compatible with stack 8.8 and above.
  • So, all packages with SVR00004 can be migrated with 8.8.0 stack as the kibana.version is either 8.8.0 or above exceptwebsphere_application_server (8.3.0).
  • For all packages, exceptwebsphere_application_server; stack used for inliner script: v8.8.0
  • Forwebsphere_application_server, stack used for inliner script: v8.3.0

How to test this PR locally

Review should include loading the dashboard into an instance with data to make sure everything is displayed properly.

Related issues

@shmsrshmsr self-assigned thisNov 7, 2023
@elasticmachine
Copy link

elasticmachine commentedNov 7, 2023•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2023-11-07T17:52:09.192+0000

  • Duration: 27 min 35 sec

Test stats 🧪

TestResults
Failed0
Passed160
Skipped0
Total160

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commentedNov 7, 2023•
edited
Loading

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (19/19)💚
Files100.0% (26/26)💚
Classes100.0% (26/26)💚
Methods95.436% (230/241)👎 -4.564
Lines98.256% (2197/2236)👎 -0.465
Conditionals100.0% (0/0)💚

@shmsr
Copy link
MemberAuthor

Please read the full PR description before reviewing.

@shmsrshmsr marked this pull request as ready for reviewNovember 9, 2023 19:44
@shmsrshmsr requested a review froma team as acode ownerNovember 9, 2023 19:44
@lalit-satapathy
Copy link
Contributor

CC: @harnish-elastic @aliabbas-elastic to review the dashboard changes as part of the pass by value is correctly being added.

Copy link
Contributor

@ali786XIali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM for the changes. Please referhere for testing details

@mrodm
Copy link
Collaborator

Hi@shmsr, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

shmsr reacted with thumbs up emoji

@lalit-satapathy
Copy link
Contributor

@shmsr,

What is pending on this as thevalidation is complete?

@shmsr
Copy link
MemberAuthor

@shmsr,

What is pending on this as thevalidation is complete?

I have to resolve the merge conflicts. I'll do it ASAP.

@shmsr
Copy link
MemberAuthor

shmsr commentedJan 3, 2024•
edited
Loading

@harnish-elastic @aliabbas-elastic I have resolved the merge conflicts. I had to inline viz in springboot from the checkout of main brain as dashboard changes had been made in the last couple of months. Otherwise, for other packages only manifest and changelog yaml's are touched.

So it'd be great if could take a look at springboot again.

ali786XI and harnish-crest-data reacted with thumbs up emoji

@botelastic
Copy link

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue asStale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough:+1. Thank you for your contribution!

@shmsrshmsrforce-pushed thefix-validation-svr00004 branch frome596616 to1da12b1CompareFebruary 7, 2024 10:50
@botelasticbotelasticbot removed the Stalled labelFeb 7, 2024
@shmsr
Copy link
MemberAuthor

Fixed merge conflicts.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with/test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc@shmsr

@elastic-sonarqube
Copy link

Quality Gate passedQuality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@shmsr
Copy link
MemberAuthor

shmsr commentedFeb 7, 2024•
edited
Loading

As latest changes in oracle_weblogic includes saved searches; inlining them could only be done for 8.10 or above stack. So leaving out oracle_weblogic.

cc: @harnish-elastic

harnish-crest-data reacted with thumbs up emoji

@shmsrshmsr merged commitf89067d intoelastic:mainFeb 7, 2024
@shmsrshmsr deleted the fix-validation-svr00004 branchFebruary 7, 2024 11:34
@elasticmachine
Copy link

Package apache_spark - 1.0.2 containing this change is available athttps://epr.elastic.co/search?package=apache_spark

@elasticmachine
Copy link

Package azure_functions - 0.2.1 containing this change is available athttps://epr.elastic.co/search?package=azure_functions

@elasticmachine
Copy link

Package hadoop - 1.5.2 containing this change is available athttps://epr.elastic.co/search?package=hadoop

@elasticmachine
Copy link

Package iis - 1.17.4 containing this change is available athttps://epr.elastic.co/search?package=iis

@elasticmachine
Copy link

Package spring_boot - 1.2.2 containing this change is available athttps://epr.elastic.co/search?package=spring_boot

@elasticmachine
Copy link

Package traefik - 1.11.1 containing this change is available athttps://epr.elastic.co/search?package=traefik

@elasticmachine
Copy link

Package websphere_application_server - 1.1.1 containing this change is available athttps://epr.elastic.co/search?package=websphere_application_server

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@devamanvdevamanvdevamanv approved these changes

@tommyers-elastictommyers-elasticAwaiting requested review from tommyers-elastic

+2 more reviewers

@harnish-crest-dataharnish-crest-dataharnish-crest-data approved these changes

@ali786XIali786XIali786XI approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shmsrshmsr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@shmsr@elasticmachine@lalit-satapathy@mrodm@devamanv@harnish-crest-data@ali786XI@andrewkroh
[8]ページ先頭
©2009-2026 Movatter.jp