- Notifications
You must be signed in to change notification settings - Fork545
Comments
[O11y][Apache Spark] Add dimension mapping for application datastream#7991
Merged
harnish-crest-data merged 5 commits intoelastic:mainfromOct 12, 2023
Conversation
elasticmachine commentedSep 27, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
elasticmachine commentedSep 27, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🌐 Coverage report
|
21 tasks
agithomas previously approved these changesOct 5, 2023
Contributor
agithomas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
Contributor
agithomas commentedOct 5, 2023
@harnish-elastic , please complete the peer review additionally. |
agithomas approved these changesOct 5, 2023
Contributor
agithomas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
milan-elastic approved these changesOct 6, 2023
Contributor
milan-elastic left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
…into apache_spark-application-add-dimensionConflicts:packages/apache_spark/changelog.ymlpackages/apache_spark/manifest.yml
elasticmachine commentedOct 12, 2023
Package apache_spark - 0.7.0 containing this change is available athttps://epr.elastic.co/search?package=apache_spark |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds dimension fields for application data stream to support TSDB enablement.
Checklist
I have reviewedtips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's
changelog.ymlfile.I have verified that Kibana version constraints are current according toguidelines.
RelatesApache Spark TSDB Enablement #7786