elastic/integrationsPublic

NotificationsYou must be signed in to change notification settings
Fork545
Star318

Comments

[O11y][Apache Spark] Add metric_type for application data stream#7795

Merged

harnish-crest-data merged 3 commits intoelastic:mainfrom

chavdaharnish:apache_spark-application-add-metric_type

Oct 12, 2023

Merged

[O11y][Apache Spark] Add metric_type for application data stream#7795
harnish-crest-data merged 3 commits intoelastic:mainfrom
chavdaharnish:apache_spark-application-add-metric_type

Conversation

Copy link

Contributor

harnish-crest-data commentedSep 13, 2023

Enhancement

What does this PR do?

This PR adds metric_type mapping for the fields of the application data stream.

Checklist

I have reviewedtips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package'schangelog.yml file.
I have verified that Kibana version constraints are current according toguidelines.

To verify the metric_type, please refer to the below mbeans type that is used for data collection

  - mbean: 'metrics:name=application.*.runtime_ms,type=gauges'    attributes:    - attr: Value      field: application.runtime.ms  - mbean: 'metrics:name=application.*.cores,type=gauges'    attributes:    - attr: Value      field: application.cores

add metric type for application data stream

77fc8a3

harnish-crest-data added the Integration:apache_sparkApache Spark label

Sep 13, 2023

harnish-crest-data self-assigned this

Sep 13, 2023

update changelog.yml

40cd686

harnish-crest-data marked this pull request as ready for review

September 13, 2023 10:44

harnish-crest-data requested a review froma team as acode owner

September 13, 2023 10:44

harnish-crest-data mentioned this pull request

Sep 13, 2023

Apache Spark TSDB Enablement#7786

Closed

21 tasks

Copy link

elasticmachine commentedSep 13, 2023•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-10-12T11:30:20.944+0000
Duration: 20 min 36 sec

Test stats 🧪

Test	Results
Failed	0
Passed	15
Skipped	0
Total	15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

Copy link

elasticmachine commentedSep 13, 2023•
edited
Loading

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`0/0`)	💚
Files	100.0% (`0/0`)	💚
Classes	100.0% (`0/0`)	💚
Methods	75.0% (`12/16`)	❕
Lines	100.0% (`0/0`)	💚
Conditionals	100.0% (`0/0`)	💚

ali786XI approved these changes

Sep 28, 2023

View reviewed changes

Copy link

Contributor

ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

agithomas reviewed

Oct 5, 2023

View reviewed changes

packages/apache_spark/data_stream/application/fields/fields.ymlShow resolvedHide resolved

agithomas approved these changes

Oct 7, 2023

View reviewed changes

Copy link

Contributor

agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Merge branch 'main' ofhttps://github.com/harnish-elastic/integrations…

82fd603

…into apache_spark-application-add-metric_typeConflicts:packages/apache_spark/changelog.ymlpackages/apache_spark/docs/README.mdpackages/apache_spark/manifest.yml

harnish-crest-data merged commit3e6d75e intoelastic:main

Oct 12, 2023

Copy link