- Notifications
You must be signed in to change notification settings - Fork545
[AWS] Fix field names for rds remove processor#7331
[AWS] Fix field names for rds remove processor#7331kaiyan-sheng merged 7 commits intoelastic:mainfrom
Conversation
elasticmachine commentedAug 9, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
zmoog left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@kaiyan-sheng Why do we need to remove the same field we're renaming? In which case the rename is not enough?
elasticmachine commentedAug 9, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🌐 Coverage report
|
kaiyan-sheng commentedAug 11, 2023
We rename it and then remove the original field name. So we don't report the same data point twice :) |
zmoog commentedAug 16, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yeah, I get it. What I meant was, for example, why do we need to remove the field |
kaiyan-sheng commentedAug 17, 2023
@zmoog Ahh sorry I completely misunderstood you! Thanks for the comment!! This is interesting! I didnt know rename processor also removes the old field! Let me double check tomorrow then :) |
kaiyan-sheng commentedAug 17, 2023
@zmoog you are right! The renamed processors deleted the old fields after done renaming. So I will change this PR to actually remove the remove processor then 😂 THANK YOU!! |
zmoog left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So we are dropping the remove processor because it's not doing any actual work since the rename processor already changes the fields name.
LGTM.
bhapas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
elasticmachine commentedAug 21, 2023
Package aws - 1.53.2 containing this change is available athttps://epr.elastic.co/search?package=aws |
Uh oh!
There was an error while loading.Please reload this page.
What does this PR do?
This pr is to drop the remove processor because it's not doing any actual work since the rename processor already changes the fields name.