Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[AWS] Fix field names for rds remove processor#7331

Merged
kaiyan-sheng merged 7 commits intoelastic:mainfrom
kaiyan-sheng:rds_metrics
Aug 21, 2023
Merged

[AWS] Fix field names for rds remove processor#7331
kaiyan-sheng merged 7 commits intoelastic:mainfrom
kaiyan-sheng:rds_metrics

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-shengkaiyan-sheng commentedAug 9, 2023
edited
Loading

What does this PR do?

This pr is to drop the remove processor because it's not doing any actual work since the rename processor already changes the fields name.

@kaiyan-shengkaiyan-sheng requested a review froma team as acode ownerAugust 9, 2023 22:47
@elasticmachine
Copy link

elasticmachine commentedAug 9, 2023
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2023-08-17T19:39:38.915+0000

  • Duration: 49 min 24 sec

Test stats 🧪

TestResults
Failed0
Passed208
Skipped4
Total212

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@zmoogzmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@kaiyan-sheng Why do we need to remove the same field we're renaming? In which case the rename is not enough?

@elasticmachine
Copy link

elasticmachine commentedAug 9, 2023
edited
Loading

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (17/17)💚
Files94.444% (17/18)
Classes94.444% (17/18)
Methods85.953% (257/299)
Lines86.024% (7509/8729)
Conditionals100.0% (0/0)💚

@kaiyan-sheng
Copy link
ContributorAuthor

@kaiyan-sheng Why do we need to remove the same field we're renaming? In which case the rename is not enough?

We rename it and then remove the original field name. So we don't report the same data point twice :)

@kaiyan-shengkaiyan-sheng requested a review froma team as acode ownerAugust 11, 2023 13:46
@kaiyan-shengkaiyan-sheng self-assigned thisAug 16, 2023
@zmoog
Copy link
Contributor

zmoog commentedAug 16, 2023
edited
Loading

We rename it and then remove the original field name. So we don't report the same data point twice :)

Yeah, I get it.

What I meant was, for example, why do we need to remove the fieldaws.rds.metrics.AuroraVolumeBytesLeftTotal.avg when renaming it makes it go away?

## request#POST _ingest/pipeline/metrics-aws.rds-1.42.0/_simulate{  "docs": [    {      "_source": {        "@timestamp": "2022-10-04T13:05:22.643+1300",        "aws": {          "rds": {            "metrics": {              "AuroraVolumeBytesLeftTotal": {                "avg": 0              }            }          }        }      }    }  ]}
## response#{  "docs": [    {      "doc": {        "_index": "_index",        "_id": "_id",        "_version": "-3",        "_source": {          "aws": {            "rds": {              "aurora_volume_left_total": {                "bytes": 0              },              "metrics": {}            }          },          "@timestamp": "2022-10-04T13:05:22.643+1300"        },        "_ingest": {          "timestamp": "2023-08-16T21:28:27.25249272Z"        }      }    }  ]}

@kaiyan-sheng
Copy link
ContributorAuthor

@zmoog Ahh sorry I completely misunderstood you! Thanks for the comment!! This is interesting! I didnt know rename processor also removes the old field! Let me double check tomorrow then :)

zmoog reacted with thumbs up emoji

@kaiyan-sheng
Copy link
ContributorAuthor

@zmoog you are right! The renamed processors deleted the old fields after done renaming. So I will change this PR to actually remove the remove processor then 😂 THANK YOU!!

Copy link
Contributor

@zmoogzmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So we are dropping the remove processor because it's not doing any actual work since the rename processor already changes the fields name.

LGTM.

kaiyan-sheng reacted with thumbs up emoji
Copy link
Contributor

@bhapasbhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@kaiyan-shengkaiyan-sheng merged commit3906382 intoelastic:mainAug 21, 2023
@kaiyan-shengkaiyan-sheng deleted the rds_metrics branchAugust 21, 2023 13:49
@elasticmachine
Copy link

Package aws - 1.53.2 containing this change is available athttps://epr.elastic.co/search?package=aws

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zmoogzmoogzmoog approved these changes

@bhapasbhapasbhapas approved these changes

Assignees

@kaiyan-shengkaiyan-sheng

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kaiyan-sheng@elasticmachine@zmoog@bhapas@andrewkroh

Comments


[8]ページ先頭

©2009-2026 Movatter.jp