elastic/integrationsPublic

NotificationsYou must be signed in to change notification settings
Fork545
Star318

[O11y][AWS] Migrate AWS Billing dashboard visualizations to lens#6644

Merged

rajvi-patel-22 merged 9 commits intoelastic:mainfrom

rajvi-patel-22:lens_migration-aws-billing

Jul 20, 2023

Merged

[O11y][AWS] Migrate AWS Billing dashboard visualizations to lens#6644
rajvi-patel-22 merged 9 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration-aws-billing

Conversation

Copy link

Contributor

rajvi-patel-22 commentedJun 21, 2023•
edited by ali786XI
Loading

Enhancement

What does this PR do?

Manually migrateAWS Billing visualizations to the lens in the current Kibana version8.8.1 itself.
Statistics forAWS Billing Lens migration:

Migration stats

AWS Billing Dashboards	Before Migration				After Migration
	Maps	Search	Lens	Visualization	Maps	Search	Lens	Visualization
[Metrics AWS] Billing Overview	0	0	0	4	0	0	4	0

Checklist

I have added an entry to my package'schangelog.yml file.
I have verified that panels are populated with data.
I have verified that panels are not distorted after being migrated to the lens.
I have updated screenshots of the dashboard.
I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

Migrated panels should be removed from visualization folder.
Migrated visualizations are populating in current Kibana version 8.7.1 itself.

Related issues

Closes[O11y][AWS Billing] Lens Migration #6361

Note:

Please refer the belowBefore Migrated screenshot to compare!

Migrate AWS Billing dashboard visualizations to lens

983c2c1

rajvi-patel-22 added the Integration:awsAWS label

Jun 21, 2023

rajvi-patel-22 self-assigned this

Jun 21, 2023

Update changelog

b869de8

Copy link

elasticmachine commentedJun 21, 2023•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-07-20T19:13:31.754+0000
Duration: 52 min 29 sec

Test stats 🧪

Test	Results
Failed	0
Passed	204
Skipped	4
Total	208

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

Copy link

elasticmachine commentedJun 21, 2023•
edited
Loading

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`17/17`)	💚
Files	94.444% (`17/18`)	👍
Classes	94.444% (`17/18`)	👍
Methods	85.953% (`257/299`)	👍
Lines	86.011% (`7501/8721`)	👍
Conditionals	100.0% (`0/0`)	💚

rajvi-patel-22 added3 commits

June 29, 2023 12:08

Merge branch 'main' of github.com:rajvi-elastic/integrations into len…

5f44184

…s_migration-aws-billing

Merge branch 'main' of github.com:rajvi-elastic/integrations into len…

f7173d9

…s_migration-aws-billing

Export dashboards from 8.8.1

840e783

rajvi-patel-22 mentioned this pull request

Jul 3, 2023

[O11y][AWS Billing] Lens Migration#6361

Closed

5 tasks

rajvi-patel-22 marked this pull request as ready for review

July 3, 2023 08:39

rajvi-patel-22 requested review froma team ascode owners

July 3, 2023 08:39

gpop63 reviewed

Jul 3, 2023

View reviewed changes

packages/aws/kibana/dashboard/aws-e6776b10-1534-11ea-841c-01bf20a6c8ba.json

		},
		"title": "",
		"type": "lens",
		"visualizationType": "lnsLegacyMetric"

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ForTotal Estimated Charges chart maybe we should use the new Metric chart type instead of the legacy one.

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@gpop63, As discussed with the@kaiyan-sheng, if we use the new metric chart and if the value is 5004 then the new metric visualization will show us 5k. It won't show us the actual value that is 5004. Also there isn't any option available to change this behavior. Hence we need to create a legacy metric for this particular panel! Let me know if you strongly feel that this should be new metric chart!

Copy link

mbondyraJul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just FYI this is changed in kibana 8.9 (custom format is added), so it can be updated at some point in the future.

mbondyra reviewed

Jul 5, 2023

View reviewed changes

packages/aws/kibana/dashboard/aws-e6776b10-1534-11ea-841c-01bf20a6c8ba.json

		}
		],
		"palette": {
		"name": "default",

Copy link

mbondyraJul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see that we usedefault palette which is great, but I think the screenshot above is still showingcompatibility palette? 🤔

Copy link

ContributorAuthor

rajvi-patel-22Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, you are right! I will update the screenshot.

Copy link

ContributorAuthor

rajvi-patel-22Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have created an issue to track this:#6835

Merge branch 'main' of github.com:rajvi-elastic/integrations into len…

cdf264c

…s_migration-aws-billing and update screenshot

Copy link

ContributorAuthor

rajvi-patel-22 commentedJul 6, 2023

/test

rajvi-patel-22 requested review fromgpop63 andmbondyra

July 6, 2023 09:06

mbondyra approved these changes

Jul 7, 2023

View reviewed changes

Copy link

mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

harnish-crest-data approved these changes

Jul 7, 2023

View reviewed changes

rajvi-patel-22 added2 commits

July 19, 2023 12:15

Export dashboards from 8.7.0

a2284c4

Merge branch 'main' of github.com:rajvi-elastic/integrations into len…

05ab99d

…s_migration-aws-billing

kaiyan-sheng approved these changes

Jul 20, 2023

View reviewed changes

Merge branch 'main' of github.com:rajvi-elastic/integrations into len…

34a37e5

…s_migration-aws-billing

rajvi-patel-22 merged commitaff8ec4 intoelastic:main

Jul 20, 2023

Copy link

elasticmachine commentedJul 20, 2023

Package aws - 1.50.2 containing this change is available athttps://epr.elastic.co/search?package=aws

Labels

Integration:aws

AWS

Movatterモバイル変換

Conversation

rajvi-patel-22 commentedJun 21, 2023• edited by ali786XILoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

What does this PR do?

Migration stats

Checklist

Author's Checklist

Related issues

Uh oh!

elasticmachine commentedJun 21, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Uh oh!

elasticmachine commentedJun 21, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

🌐 Coverage report

Uh oh!

gpop63Jul 3, 2023

Choose a reason for hiding this comment

Uh oh!

rajvi-patel-22Jul 5, 2023

Choose a reason for hiding this comment

Uh oh!

mbondyraJul 5, 2023

Choose a reason for hiding this comment

Uh oh!

mbondyraJul 5, 2023

Choose a reason for hiding this comment

Uh oh!

rajvi-patel-22Jul 5, 2023

Choose a reason for hiding this comment

Uh oh!

rajvi-patel-22Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

rajvi-patel-22 commentedJul 6, 2023

Uh oh!

mbondyra left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commentedJul 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

rajvi-patel-22 commentedJun 21, 2023•
edited by ali786XI
Loading

elasticmachine commentedJun 21, 2023•
edited
Loading

elasticmachine commentedJun 21, 2023•
edited
Loading