Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[AWS] Add agent.id field to be set as dimension for TSDB migration#6421

Merged
constanca-m merged 5 commits intoelastic:mainfrom
constanca-m:aws-add-agent-id
Jun 8, 2023
Merged

[AWS] Add agent.id field to be set as dimension for TSDB migration#6421
constanca-m merged 5 commits intoelastic:mainfrom
constanca-m:aws-add-agent-id

Conversation

@constanca-m
Copy link
Contributor

What does this PR do?

The fieldagent.id needs to be set as dimension for TSDB migration. Reasoning for this can be found in the thread following the comment#5193 (comment)

Note:agent.id hasn't been added to all data streams yet, just to the ones that were migrated to TSDB already.

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commentedJun 1, 2023•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2023-06-08T06:13:09.755+0000

  • Duration: 52 min 24 sec

Test stats 🧪

TestResults
Failed0
Passed190
Skipped4
Total194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commentedJun 1, 2023•
edited
Loading

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (15/15)💚
Files93.75% (15/16)👎 -6.25
Classes93.75% (15/16)👎 -6.25
Methods85.921% (238/277)👎 -14.079
Lines85.925% (7387/8597)👎 -4.896
Conditionals100.0% (0/0)💚

name: aws
title: AWS
version: 1.37.3
version: 1.38.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wouldn't be ok to keep the version as 1.37.4?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes on 1.37 are not related to TSDB, that is why I bumped to 1.30

@agithomas
Copy link
Contributor

Please confirm that you have verified the number of dimensions are within 16 , after making this change, for all datastreams?

@constanca-m
Copy link
ContributorAuthor

Please confirm that you have verified the number of dimensions are within 16 , after making this change, for all datastreams?

Yes@agithomas:
DynamoDB: 11
EBS: 4
ECS: 5
ELB: 7
Kinesis: 4
Lambda: 6
Natgateway: 4
Redshift: 11
Usage: 7

Copy link
Contributor

@agithomasagithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Copy link
Contributor

@tommyers-elastictommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

constanca-mand others added2 commitsJune 8, 2023 08:10
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-mconstanca-m merged commite94623d intoelastic:mainJun 8, 2023
@constanca-mconstanca-m deleted the aws-add-agent-id branchJune 8, 2023 07:57
@elasticmachine
Copy link

Package aws - 1.42.0 containing this change is available athttps://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull requestJun 15, 2023
…6421)* Add agent.id as dimensionSigned-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@agithomasagithomasagithomas approved these changes

@tommyers-elastictommyers-elastictommyers-elastic approved these changes

@tetianakravchenkotetianakravchenkoAwaiting requested review from tetianakravchenko

Assignees

@constanca-mconstanca-m

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@constanca-m@elasticmachine@agithomas@tommyers-elastic

Comments

[8]ページ先頭
©2009-2026 Movatter.jp