Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Github] Remove duplicate repository fields not in github root#6401

Merged
kcreddy merged 3 commits intoelastic:mainfrom
kcreddy:github-repo-name-fix
Jun 1, 2023
Merged

[Github] Remove duplicate repository fields not in github root#6401
kcreddy merged 3 commits intoelastic:mainfrom
kcreddy:github-repo-name-fix

Conversation

@kcreddy
Copy link
Contributor

@kcreddykcreddy commentedMay 31, 2023
edited
Loading

What does this PR do?

Fixes bug ingithub.issues datastream where some of the documents (ingested with norepository UI config) havegithub.issues.repository.name while also havinggithub.repository.name.

Since othergithub datastreams are usinggithub.repository.name we could save some space and have more consistency if we dropped github.issues.repository.name

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@kcreddykcreddy added Integration:githubGitHub bugfixPull request that fixes a bug issue labelsMay 31, 2023
@kcreddykcreddy self-assigned thisMay 31, 2023
@kcreddykcreddy marked this pull request as ready for reviewMay 31, 2023 13:07
@kcreddykcreddy requested a review froma team as acode ownerMay 31, 2023 13:07
@elasticmachine
Copy link

elasticmachine commentedMay 31, 2023
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2023-05-31T17:03:02.961+0000

  • Duration: 16 min 29 sec

Test stats 🧪

TestResults
Failed0
Passed34
Skipped0
Total34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (5/5)💚
Files100.0% (5/5)💚
Classes100.0% (5/5)💚
Methods100.0% (64/64)💚
Lines93.815% (986/1051)
Conditionals100.0% (0/0)💚

1 similar comment
@elasticmachine
Copy link

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (5/5)💚
Files100.0% (5/5)💚
Classes100.0% (5/5)💚
Methods100.0% (64/64)💚
Lines93.815% (986/1051)
Conditionals100.0% (0/0)💚

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

Package github - 1.12.1 containing this change is available athttps://epr.elastic.co/search?package=github

agithomas pushed a commit to agithomas/integrations that referenced this pull requestJun 5, 2023
…ic#6401)* Remove duplicate repo fields not in github root* update changelog
sodhikirti07 pushed a commit that referenced this pull requestJun 15, 2023
* Remove duplicate repo fields not in github root* update changelog
@kcreddykcreddy deleted the github-repo-name-fix branchFebruary 7, 2025 09:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@andrewkrohandrewkrohandrewkroh approved these changes

Assignees

@kcreddykcreddy

Labels

bugfixPull request that fixes a bug issueIntegration:githubGitHub

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kcreddy@elasticmachine@andrewkroh

Comments


[8]ページ先頭

©2009-2026 Movatter.jp