- Notifications
You must be signed in to change notification settings - Fork545
[AWS] Add metric type to VPN, Firewall and Transit Gateway data streams#6365
Merged
constanca-m merged 8 commits intoelastic:mainfromJun 5, 2023
Merged
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
elasticmachine commentedMay 30, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
💚 Build Succeeded
Expand to view the summaryBuild stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub commentsTo re-run your PR in the CI, just comment with:
|
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
elasticmachine commentedMay 30, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🌐 Coverage report
|
tetianakravchenko approved these changesJun 1, 2023
paolafrancesca approved these changesJun 5, 2023
This was referencedJun 5, 2023
ContributorAuthor
constanca-m commentedJun 5, 2023
/test |
elasticmachine commentedJun 5, 2023
Package aws - 1.38.2 containing this change is available athttps://epr.elastic.co/search?package=aws |
sodhikirti07 pushed a commit that referenced this pull requestJun 15, 2023
…ms (#6365)* Add metric type to VPN.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Add metric type to Firewall.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Add metric type to Transit gateway.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Update version.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Update changelog.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Update md filesSigned-off-by: constanca-m <constanca.manteigas@elastic.co>---------Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add metric type to VPN, Firewall and Transit Gateway data streams.
All metrics are gauge, since they go up and down and might not relate to the previous values. For example, some metrics may have a specific time window of 1 minute. For that minute, all values are summed to obtain the final value of a field, but as soon as that time window finishes, the value restarts again. There is no guarantee that the next value will be equal or higher than the previous value.
Author's Checklist
How to test this PR locally
Refer to#6293.
Related issues
Relates to#6293.