Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Allow routing for integrations that are not input packages#6340

Merged
gsantoro merged 19 commits intoelastic:mainfrom
gsantoro:feature/allow_routing
Jun 13, 2023
Merged

Allow routing for integrations that are not input packages#6340
gsantoro merged 19 commits intoelastic:mainfrom
gsantoro:feature/allow_routing

Conversation

@gsantoro
Copy link
Contributor

What does this PR do?

This PR add permissions to reroute logs tologs-*-* for integrations that are not input packages.

The full list of packages to edit is:

kubernetes.container_logs
system.syslog
activemq.log
auditd.log
aws.cloudwatch_logs
aws.ec2_logs
kafka.log
docker.container_logs

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gsantorogsantoro added the enhancementNew feature or request labelMay 26, 2023
@gsantorogsantoro requested a review froma team as acode ownerMay 26, 2023 12:21
@gsantorogsantoro self-assigned thisMay 26, 2023
@gsantorogsantoro requested review fromcmacknz andrdnerMay 26, 2023 12:21
@gsantorogsantoro requested review froma team ascode ownersMay 26, 2023 12:25
@gsantorogsantoro added draftDraft and removed draftDraft labelsMay 26, 2023
@elasticmachine
Copy link

elasticmachine commentedMay 26, 2023•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2023-06-13T12:11:58.706+0000

  • Duration: 52 min 27 sec

Test stats 🧪

TestResults
Failed0
Passed531
Skipped4
Total535

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commentedMay 26, 2023•
edited
Loading

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (22/22)💚
Files95.833% (23/24)👎 -4.167
Classes95.833% (23/24)👎 -4.167
Methods84.645% (441/521)👎 -4.244
Lines90.563% (12466/13765)👎 -9.437
Conditionals100.0% (0/0)💚

Copy link
Contributor

@tommyers-elastictommyers-elastic left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

CSP integration changes look good to me - only thing on my mind is the future - someone looking at this file without the context of routing rules etc, they might be able to look up what these settings do, but there is some implicit coupling to other parts of the system here that i think would be good to call out 'at the source'. can we comment what the settings are for?

gsantoro reacted with thumbs up emoji
@gsantoro
Copy link
ContributorAuthor

about

CSP integration changes look good to me - only thing on my mind is the future - someone looking at this file without the context of routing rules etc, they might be able to look up what these settings do, but there is some implicit coupling to other parts of the system here that i think would be good to call out 'at the source'. can we comment what the settings are for?

I think that we could add a comment like

# Ensures agents have permissions to write data to `logs-nginx.*-*`

like the one you can see athere

@gsantoro
Copy link
ContributorAuthor

I have tested now the rerouting of logs for the following use cases:

  • docker.container_logs in 8.9.0-SNAPSHOT Elastic stack
  • docker.container_logs in 8.8.0 Elastic stack
felixbarny reacted with rocket emoji

@gsantoro
Copy link
ContributorAuthor

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

cc@gsantoro

@gsantorogsantoro merged commit835c3c7 intoelastic:mainJun 13, 2023
@gsantorogsantoro deleted the feature/allow_routing branchJune 13, 2023 13:29
@elasticmachine
Copy link

Package activemq - 0.10.0 containing this change is available athttps://epr.elastic.co/search?package=activemq

@elasticmachine
Copy link

Package auditd - 3.9.0 containing this change is available athttps://epr.elastic.co/search?package=auditd

@elasticmachine
Copy link

Package aws - 1.44.0 containing this change is available athttps://epr.elastic.co/search?package=aws

@elasticmachine
Copy link

Package docker - 2.6.0 containing this change is available athttps://epr.elastic.co/search?package=docker

@elasticmachine
Copy link

Package kafka - 1.7.0 containing this change is available athttps://epr.elastic.co/search?package=kafka

@elasticmachine
Copy link

Package kubernetes - 1.42.0 containing this change is available athttps://epr.elastic.co/search?package=kubernetes

@elasticmachine
Copy link

Package system - 1.33.0 containing this change is available athttps://epr.elastic.co/search?package=system

name: system
title: System
version: 1.32.0-beta.2
version: 1.33.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@gsantoro With this change you accidentally release TSDB which was still in beta!

gsantoro reacted with confused emoji
Copy link
Member

@ishleenk17ishleenk17Jun 28, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@gsantoro Are we considering System Integration TSDB as GA now or are we planning to revert the change ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TSDB in system is now approved to be in GA.#6607

sodhikirti07 pushed a commit that referenced this pull requestJun 15, 2023
* fix system test for kubernetes integration for k8s v1.27.0* minor changes from formatting* syslong changes* revert a merge conflict* add permissions to selected list of datastreams* update PR id* fix merge conflict with main* Increment minor version instead of bugfix version* added comments for new settings* update activemq version---------Co-authored-by: Felix Barnsteiner <felix.barnsteiner@elastic.co>
@P1llusP1llus mentioned this pull requestOct 25, 2023
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ruflinruflinruflin left review comments

@felixbarnyfelixbarnyfelixbarny left review comments

@lalit-satapathylalit-satapathylalit-satapathy approved these changes

@ishleenk17ishleenk17ishleenk17 left review comments

@gizasgizasgizas approved these changes

@P1llusP1llusP1llus approved these changes

@leehinmanleehinmanleehinman approved these changes

@tommyers-elastictommyers-elastictommyers-elastic approved these changes

@rdnerrdnerAwaiting requested review from rdnerrdner was automatically assigned from elastic/elastic-agent-data-plane

@cmacknzcmacknzAwaiting requested review from cmacknzcmacknz was automatically assigned from elastic/elastic-agent-data-plane

@tetianakravchenkotetianakravchenkoAwaiting requested review from tetianakravchenkotetianakravchenko was automatically assigned from elastic/obs-cloudnative-monitoring

Assignees

@gsantorogsantoro

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow routing for integrations that are not input packages

11 participants

@gsantoro@elasticmachine@felixbarny@ruflin@gizas@P1llus@leehinman@lalit-satapathy@ishleenk17@tommyers-elastic@andrewkroh

Comments

[8]ページ先頭
©2009-2026 Movatter.jp