Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[AWS] Add dimensions to firewall, transit gateway and vpn data streams#6339

Merged
constanca-m merged 11 commits intoelastic:mainfrom
constanca-m:aws-add-dimensions-vpn
Jun 5, 2023
Merged

[AWS] Add dimensions to firewall, transit gateway and vpn data streams#6339
constanca-m merged 11 commits intoelastic:mainfrom
constanca-m:aws-add-dimensions-vpn

Conversation

@constanca-m
Copy link
Contributor

@constanca-mconstanca-m commentedMay 26, 2023
edited
Loading

What does this PR do?

Add dimensions to firewall, transit gateway and vpn data streams.

Transit gateway: A transit gateway can have more than one attachment, so it needs to be set as dimensions as well. A transit gateway is unique per AWS account.

VPN: Each tunnel belongs to a VPN. Combination tunnel id + vpn id is unique within the AWS scope account (account id + region).
Note: for each VPN site to site connection, there are four documents sent to ES. Is this expected?
image

Firewall: The firewall name is unique per region in an account. A firewall can have more than one engine and one Availability Zone, so both need to be set as dimension to avoid documents being overwritten. Since we can have more than one custom action in the same firewall, we also set that as dimension.
Question:CustomAction fields holds the name of the action. Since a firewall can have different groups (names are unique, but we don't have access to that field in this data stream), then we can also have different custom actions with the exact same name associated with one firewall. I tried to reproduce this, but even with multiple rules with the same name I kept receiving just one document for each rule. Without considering TSDB, can we receive two documents for the same action at the same time? If so, dimensions are not enough for this data stream.

Regarding ECS fields, more info can be found here#5193 (comment).

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

Author's Checklist

  • Verification of the count of documents (before & after TSDB enablement) in Discover Interface
  • Verify if field mapping is correct in the data stream template.

How to test this PR locally

Refer to#6293.

Related issues

Relates to#6293.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Copy link
Contributor

@agithomasagithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.36.9"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: in#6365 we bumped minor version, here only patch one
why the difference? :)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1.37 changes were not related to TSDB, that is why I bumped to 1.38 in that PR. Unlike here, since 1.36.8 was a change to add dimensions.

@elasticmachine
Copy link

elasticmachine commentedJun 5, 2023
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2023-06-05T12:31:16.806+0000

  • Duration: 47 min 34 sec

Test stats 🧪

TestResults
Failed0
Passed188
Skipped4
Total192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commentedJun 5, 2023
edited
Loading

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (15/15)💚
Files93.75% (15/16)👎 -6.25
Classes93.75% (15/16)👎 -6.25
Methods86.131% (236/274)👎 -10.095
Lines85.925% (7387/8597)👎 -3.963
Conditionals100.0% (0/0)💚

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-mconstanca-m merged commit67f52c8 intoelastic:mainJun 5, 2023
@constanca-mconstanca-m deleted the aws-add-dimensions-vpn branchJune 5, 2023 13:22
@elasticmachine
Copy link

Package aws - 1.38.3 containing this change is available athttps://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull requestJun 15, 2023
#6339)* Add dimensions VPN.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Add dimensions transit gateway.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Add dimensions firewall.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Update version.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Update changelog.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Add 2 ecs dimension fields.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Remove cloud.availability_zone as dimension (not present)Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Update md.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>* Resolve conflict.Signed-off-by: constanca-m <constanca.manteigas@elastic.co>---------Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@agithomasagithomasagithomas approved these changes

@tetianakravchenkotetianakravchenkoAwaiting requested review from tetianakravchenko

+1 more reviewer

@paolafrancescapaolafrancescapaolafrancesca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@constanca-mconstanca-m

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@constanca-m@elasticmachine@paolafrancesca@agithomas

Comments


[8]ページ先頭

©2009-2026 Movatter.jp