Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

[AWS][Natgateway] Add metric type to fields#6105

Merged
constanca-m merged 3 commits intoelastic:mainfrom
constanca-m:nat-add-metrics
May 22, 2023
Merged

[AWS][Natgateway] Add metric type to fields#6105
constanca-m merged 3 commits intoelastic:mainfrom
constanca-m:nat-add-metrics

Conversation

@constanca-m
Copy link
Contributor

What does this PR do?

Add metric type to natgateway data stream fields, necessary to support TSDB in the future.

Details

Gauge and counter fields were defined based on:

  1. The metrics that represent a specific value in time, without consideration for the previous one, are gauge.
  2. If a metric keeps increment and decrementing, it is a gauge.
  3. If a metric is cumulative, then it is a counter - but it can only increment.

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

How to test this PR locally

Refer to#6101

Related issues

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-mconstanca-m mentioned this pull requestMay 5, 2023
6 tasks
@elasticmachine
Copy link

elasticmachine commentedMay 5, 2023•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2023-05-22T08:58:03.786+0000

  • Duration: 47 min 46 sec

Test stats 🧪

TestResults
Failed0
Passed188
Skipped4
Total192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commentedMay 5, 2023•
edited
Loading

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (15/15)💚
Files93.75% (15/16)👎 -1.25
Classes93.75% (15/16)👎 -1.25
Methods86.131% (236/274)👎 -1.689
Lines85.925% (7387/8597)👎 -0.542
Conditionals100.0% (0/0)💚

@constanca-mconstanca-m merged commitc3c694a intoelastic:mainMay 22, 2023
@constanca-mconstanca-m deleted the nat-add-metrics branchMay 22, 2023 09:46
@elasticmachine
Copy link

Package aws - 1.36.6 containing this change is available athttps://epr.elastic.co/search?package=aws

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kaiyan-shengkaiyan-shengkaiyan-sheng approved these changes

@tetianakravchenkotetianakravchenkotetianakravchenko approved these changes

@agithomasagithomasAwaiting requested review from agithomas

Assignees

@constanca-mconstanca-m

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@constanca-m@elasticmachine@kaiyan-sheng@tetianakravchenko
[8]ページ先頭
©2009-2026 Movatter.jp